Skip to content

Conversation

@deardeng
Copy link
Contributor

…ime errors (#51647)"

This reverts commit 9c8cf19.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jul 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34187 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cb5e30cdb36e395e684d6efea8a65a0da2202c19, data reload: false

------ Round 1 ----------------------------------
q1	17631	5766	5715	5715
q2	1959	283	177	177
q3	10313	1291	705	705
q4	10210	1038	505	505
q5	7472	2400	2262	2262
q6	184	176	131	131
q7	908	760	649	649
q8	9315	1315	1068	1068
q9	7057	5150	5126	5126
q10	6906	2376	1959	1959
q11	462	278	262	262
q12	353	371	215	215
q13	17777	3462	2987	2987
q14	231	243	220	220
q15	526	463	467	463
q16	409	440	372	372
q17	552	839	361	361
q18	7438	7018	6971	6971
q19	1948	969	566	566
q20	324	314	214	214
q21	3388	3110	2266	2266
q22	1066	1068	993	993
Total cold run time: 106429 ms
Total hot run time: 34187 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5846	5805	5897	5805
q2	238	311	220	220
q3	2106	2564	2202	2202
q4	1338	1736	1356	1356
q5	4399	4398	4467	4398
q6	217	177	135	135
q7	1891	1897	1898	1897
q8	2672	2453	2401	2401
q9	7371	7367	7381	7367
q10	3184	3456	2910	2910
q11	575	501	520	501
q12	702	765	631	631
q13	3364	3698	3274	3274
q14	287	318	321	318
q15	506	454	465	454
q16	454	552	535	535
q17	1167	1456	1383	1383
q18	8034	7753	7741	7741
q19	13266	969	1009	969
q20	2069	2007	1772	1772
q21	15113	4386	4315	4315
q22	1068	1037	984	984
Total cold run time: 75867 ms
Total hot run time: 51568 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174018 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cb5e30cdb36e395e684d6efea8a65a0da2202c19, data reload: false

============================================
query1	1009	410	420	410
query2	6520	1918	1687	1687
query3	6780	226	219	219
query4	27192	24048	23131	23131
query5	4326	615	532	532
query6	342	249	217	217
query7	4640	512	298	298
query8	291	245	244	244
query9	8577	3207	3161	3161
query10	445	343	282	282
query11	15723	14981	14929	14929
query12	194	139	131	131
query13	1657	555	405	405
query14	9885	7723	7664	7664
query15	221	189	168	168
query16	7129	647	461	461
query17	950	742	612	612
query18	2001	442	319	319
query19	209	207	184	184
query20	188	147	137	137
query21	215	135	102	102
query22	4228	4287	3974	3974
query23	34581	34813	34540	34540
query24	5345	2385	2489	2385
query25	499	504	458	458
query26	708	289	163	163
query27	2040	495	345	345
query28	2860	2296	2297	2296
query29	607	609	496	496
query30	284	221	200	200
query31	853	793	716	716
query32	89	76	76	76
query33	472	413	383	383
query34	799	899	516	516
query35	806	847	756	756
query36	1021	1026	920	920
query37	130	112	90	90
query38	4000	4026	3958	3958
query39	1443	1386	1383	1383
query40	256	150	141	141
query41	67	66	61	61
query42	146	128	128	128
query43	521	514	471	471
query44	1396	878	870	870
query45	201	199	186	186
query46	937	1058	691	691
query47	1871	1830	1813	1813
query48	397	431	313	313
query49	703	506	416	416
query50	683	666	428	428
query51	5575	5665	5555	5555
query52	133	128	122	122
query53	259	291	209	209
query54	661	644	565	565
query55	90	91	89	89
query56	371	367	364	364
query57	1238	1257	1139	1139
query58	338	328	339	328
query59	2602	2631	2545	2545
query60	405	393	379	379
query61	125	121	164	121
query62	774	724	668	668
query63	249	213	221	213
query64	2352	1100	739	739
query65	4238	4163	4168	4163
query66	1069	450	329	329
query67	query68	18022	840	605	605
query69	1013	314	282	282
query70	1445	1144	1128	1128
query71	702	346	325	325
query72	9166	2299	4695	2299
query73	3138	763	352	352
query74	9023	9089	8845	8845
query75	7681	3143	2663	2663
query76	8668	1276	787	787
query77	1169	400	346	346
query78	9636	12170	9188	9188
query79	15480	667	577	577
query80	2178	581	503	503
query81	562	267	247	247
query82	539	151	115	115
query83	371	297	266	266
query84	298	99	88	88
query85	917	368	343	343
query86	354	315	298	298
query87	4367	4220	4143	4143
query88	5670	2224	2188	2188
query89	491	374	321	321
query90	2467	228	225	225
query91	157	142	112	112
query92	88	71	68	68
query93	7109	974	668	668
query94	1164	392	288	288
query95	428	332	317	317
query96	497	586	280	280
query97	2704	2765	2659	2659
query98	250	235	221	221
query99	1488	1428	1277	1277
Total cold run time: 304158 ms
Total hot run time: 174018 ms

@deardeng
Copy link
Contributor Author

deardeng commented Aug 7, 2025

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 58.31% (16385/28098)
Line Coverage 47.20% (148114/313787)
Region Coverage 36.16% (110807/306447)
Branch Coverage 39.08% (49258/126040)

@doris-robot
Copy link

TPC-H: Total hot run time: 33836 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1ccc07696e9f945d35bb54c6830db2326aa1f4f0, data reload: false

------ Round 1 ----------------------------------
q1	17629	5291	5281	5281
q2	1935	299	188	188
q3	10285	1413	725	725
q4	10221	1025	514	514
q5	7528	2307	2354	2307
q6	185	166	133	133
q7	887	781	626	626
q8	9301	1315	1087	1087
q9	6798	5092	5150	5092
q10	6918	2368	1954	1954
q11	490	281	267	267
q12	369	383	235	235
q13	17760	3523	3013	3013
q14	239	273	226	226
q15	529	467	459	459
q16	435	417	369	369
q17	577	845	361	361
q18	7217	7091	6902	6902
q19	1087	984	582	582
q20	341	327	218	218
q21	3464	3111	2275	2275
q22	1028	1053	1022	1022
Total cold run time: 105223 ms
Total hot run time: 33836 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5378	5387	5375	5375
q2	236	309	213	213
q3	2092	2593	2165	2165
q4	1347	1747	1321	1321
q5	4139	4383	4497	4383
q6	231	180	135	135
q7	2000	1936	1829	1829
q8	2614	2524	2548	2524
q9	7380	7234	7487	7234
q10	3492	3364	2828	2828
q11	551	510	490	490
q12	716	801	604	604
q13	3480	3838	3223	3223
q14	292	327	300	300
q15	506	488	472	472
q16	486	506	456	456
q17	1219	1477	1417	1417
q18	14540	7871	7665	7665
q19	14498	1013	1147	1013
q20	3363	2080	1851	1851
q21	15285	4588	4259	4259
q22	1072	1029	983	983
Total cold run time: 84917 ms
Total hot run time: 50740 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 170395 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1ccc07696e9f945d35bb54c6830db2326aa1f4f0, data reload: false

============================================
query1	1003	418	443	418
query2	6543	1917	1671	1671
query3	6749	232	221	221
query4	27809	23591	22872	22872
query5	4332	667	527	527
query6	326	257	257	257
query7	4634	529	304	304
query8	281	243	230	230
query9	8605	2931	3036	2931
query10	444	344	287	287
query11	15815	15024	14666	14666
query12	181	139	135	135
query13	1654	565	415	415
query14	8622	5845	5868	5845
query15	210	187	163	163
query16	7137	649	455	455
query17	925	765	624	624
query18	1988	465	331	331
query19	228	216	195	195
query20	156	144	144	144
query21	224	131	111	111
query22	3928	4075	3763	3763
query23	34633	34229	34382	34229
query24	8179	2412	2426	2412
query25	627	544	480	480
query26	1250	299	167	167
query27	2702	530	373	373
query28	4398	2371	2347	2347
query29	845	625	524	524
query30	313	238	195	195
query31	914	849	736	736
query32	94	77	80	77
query33	579	436	369	369
query34	841	874	519	519
query35	843	814	793	793
query36	1028	1039	941	941
query37	136	114	94	94
query38	4003	3941	3986	3941
query39	1470	1362	1361	1361
query40	238	149	133	133
query41	66	60	55	55
query42	141	128	124	124
query43	516	521	488	488
query44	1470	877	893	877
query45	201	192	195	192
query46	961	1071	669	669
query47	1770	1824	1772	1772
query48	412	431	321	321
query49	715	523	417	417
query50	689	680	424	424
query51	4168	4236	4238	4236
query52	129	137	123	123
query53	263	297	228	228
query54	669	645	560	560
query55	98	89	90	89
query56	352	362	344	344
query57	1208	1220	1162	1162
query58	349	345	342	342
query59	2603	2671	2592	2592
query60	407	426	397	397
query61	126	122	119	119
query62	812	703	667	667
query63	256	213	213	213
query64	4367	1102	773	773
query65	4239	4141	4115	4115
query66	1149	450	327	327
query67	query68	17198	921	1007	921
query69	1044	280	290	280
query70	1378	1099	1098	1098
query71	676	321	338	321
query72	9128	2280	2172	2172
query73	3592	729	358	358
query74	9024	9079	8688	8688
query75	7294	3100	2668	2668
query76	8547	1232	801	801
query77	1166	422	342	342
query78	9588	11501	9687	9687
query79	14358	707	580	580
query80	1460	551	494	494
query81	544	262	235	235
query82	404	156	122	122
query83	397	287	273	273
query84	306	96	81	81
query85	815	437	338	338
query86	366	313	320	313
query87	4254	4207	4121	4121
query88	5115	2190	2230	2190
query89	485	372	318	318
query90	2554	229	226	226
query91	146	141	113	113
query92	86	76	69	69
query93	5989	1018	655	655
query94	947	416	278	278
query95	390	338	323	323
query96	508	592	279	279
query97	2665	2744	2621	2621
query98	257	236	225	225
query99	1453	1476	1323	1323
Total cold run time: 305157 ms
Total hot run time: 170395 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.73 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1ccc07696e9f945d35bb54c6830db2326aa1f4f0, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.05	0.04
query3	0.25	0.07	0.08
query4	1.61	0.10	0.10
query5	0.40	0.43	0.44
query6	1.22	0.66	0.66
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.58	0.48	0.46
query10	0.54	0.54	0.53
query11	0.16	0.10	0.11
query12	0.15	0.12	0.11
query13	0.66	0.65	0.65
query14	0.95	1.06	1.12
query15	0.94	0.88	0.88
query16	0.39	0.40	0.38
query17	1.07	1.04	1.09
query18	0.21	0.21	0.20
query19	2.03	1.91	1.87
query20	0.02	0.01	0.02
query21	15.37	0.88	0.54
query22	0.75	1.06	0.65
query23	15.11	1.17	0.66
query24	6.35	1.51	0.35
query25	0.41	0.21	0.09
query26	0.64	0.15	0.12
query27	0.06	0.05	0.06
query28	9.62	0.87	0.45
query29	12.58	3.89	3.35
query30	3.06	2.99	2.97
query31	2.82	0.57	0.39
query32	3.24	0.57	0.50
query33	3.05	3.17	3.22
query34	16.02	5.42	4.93
query35	4.95	4.97	5.06
query36	0.69	0.52	0.50
query37	0.10	0.07	0.08
query38	0.06	0.05	0.05
query39	0.04	0.03	0.03
query40	0.17	0.13	0.14
query41	0.08	0.04	0.03
query42	0.04	0.02	0.03
query43	0.04	0.04	0.04
Total cold run time: 106.62 s
Total hot run time: 32.73 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.25% (22406/27575)
Line Coverage 73.99% (232118/313725)
Region Coverage 61.42% (193251/314650)
Branch Coverage 65.38% (83409/127568)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

PR approved by anyone and no changes requested.

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit b9c1b66 into apache:master Aug 8, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants