Skip to content

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Jul 30, 2025

What problem does this PR solve?

Fix missing logic

#46221 fix rename
but when developing vcg logic, missing pr #46221 functionality
pick form vcg branch, so miss #46221 logic,

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@deardeng deardeng requested a review from morrySnow as a code owner July 30, 2025 11:22
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 66.67% (14/21) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.10% (1210/1492)
Line Coverage 65.29% (21333/32676)
Region Coverage 66.80% (10727/16059)
Branch Coverage 56.46% (5646/10000)

@deardeng
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 66.67% (14/21) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.10% (1210/1492)
Line Coverage 65.27% (21327/32676)
Region Coverage 66.72% (10714/16059)
Branch Coverage 56.42% (5642/10000)

@morrySnow morrySnow merged commit 32488c7 into apache:branch-3.1 Jul 31, 2025
23 checks passed
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Sep 28, 2025
…e#54106)

### What problem does this PR solve?

Fix missing logic

apache#46221 fix rename
but when developing vcg logic, missing pr apache#46221 functionality
pick form vcg branch, so miss apache#46221 logic,
gavinchou pushed a commit that referenced this pull request Sep 29, 2025
… (#56558)

Fix missing logic

pick from #54106

#46221 fix rename
but when developing vcg logic, missing pr #46221 functionality pick form
vcg branch, so miss #46221 logic,
github-actions bot pushed a commit that referenced this pull request Sep 29, 2025
… (#56558)

Fix missing logic

pick from #54106

#46221 fix rename
but when developing vcg logic, missing pr #46221 functionality pick form
vcg branch, so miss #46221 logic,
dataroaring pushed a commit that referenced this pull request Sep 29, 2025
… pick (#54106) #56558 (#56629)

Cherry-picked from #56558

Co-authored-by: deardeng <dengxin@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants