Skip to content

Conversation

@deardeng
Copy link
Contributor

What problem does this PR solve?

Fix missing logic

pick from #54106

#46221 fix rename
but when developing vcg logic, missing pr #46221 functionality pick form vcg branch, so miss #46221 logic,

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…e#54106)

### What problem does this PR solve?

Fix missing logic

apache#46221 fix rename
but when developing vcg logic, missing pr apache#46221 functionality
pick form vcg branch, so miss apache#46221 logic,
@Thearas
Copy link
Contributor

Thearas commented Sep 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 66.67% (14/21) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.95% (1632/1944)
Line Coverage 68.22% (28829/42258)
Region Coverage 68.46% (14215/20763)
Branch Coverage 58.72% (7570/12892)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 28, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou self-requested a review September 29, 2025 06:40
@gavinchou gavinchou merged commit 1c457b0 into apache:master Sep 29, 2025
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 29, 2025
… (#56558)

Fix missing logic

pick from #54106

#46221 fix rename
but when developing vcg logic, missing pr #46221 functionality pick form
vcg branch, so miss #46221 logic,
dataroaring pushed a commit that referenced this pull request Sep 29, 2025
… pick (#54106) #56558 (#56629)

Cherry-picked from #56558

Co-authored-by: deardeng <dengxin@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants