Skip to content

[fix](checker) Fix inverted check and test for checker #54403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Aug 7, 2025
Merged

[fix](checker) Fix inverted check and test for checker #54403

dataroaring merged 1 commit into from
Aug 7, 2025

Conversation

@wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Aug 6, 2025 •
edited
Loading

related #53876

test:

[ RUN      ] CheckerTest.normal_check_index_file_v1
[ RUN      ] CheckerTest.normal_inverted_check_index_file_v1
[ RUN      ] CheckerTest.normal_check_index_file_v2
[ RUN      ] CheckerTest.normal_inverted_check_index_file_v2
[ RUN      ] CheckerTest.abnormal_check_index_file_v1 (loss key)
[ RUN      ] CheckerTest.abnormal_inverted_check_index_file_v1 (loss file)
[ RUN      ] CheckerTest.abnormal_inverted_check_index_file_v2 (loss file)
[ RUN      ] CheckerTest.abnormal_check_index_file_v2 (loss key)

@Thearas
Copy link
Contributor

Thearas commented Aug 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Aug 6, 2025

run buildall

@wyxxxcat wyxxxcat force-pushed the fix_inverted_check branch from 495b08e to 26dada9 Compare August 6, 2025 09:59
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Aug 6, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 6, 2025

Cloud UT Coverage Report

Increment line coverage 70.59% (12/17) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.79% (1406/1719)
Line Coverage 66.03% (23975/36309)
Region Coverage 67.25% (11894/17687)
Branch Coverage 56.93% (6230/10944)

gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
@wyxxxcat wyxxxcat force-pushed the fix_inverted_check branch from 26dada9 to ecefdfd Compare August 7, 2025 03:00
@wyxxxcat wyxxxcat requested a review from gavinchou August 7, 2025 03:01
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Aug 7, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 7, 2025

Cloud UT Coverage Report

Increment line coverage 68.00% (17/25) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.79% (1406/1719)
Line Coverage 66.09% (24010/36328)
Region Coverage 67.35% (11921/17699)
Branch Coverage 56.96% (6240/10956)

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Aug 7, 2025

run cloud_p0

dataroaring
dataroaring approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 6c960c5 into apache:master Aug 7, 2025
29 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 7, 2025
@wyxxxcat
[fix](checker) Fix inverted check and test for checker (#54403)
e1ebae5 
related #53876 

test:
```
[ RUN      ] CheckerTest.normal_check_index_file_v1
[ RUN      ] CheckerTest.normal_inverted_check_index_file_v1
[ RUN      ] CheckerTest.normal_check_index_file_v2
[ RUN      ] CheckerTest.normal_inverted_check_index_file_v2
[ RUN      ] CheckerTest.abnormal_check_index_file_v1 (loss key)
[ RUN      ] CheckerTest.abnormal_inverted_check_index_file_v1 (loss file)
[ RUN      ] CheckerTest.abnormal_inverted_check_index_file_v2 (loss file)
[ RUN      ] CheckerTest.abnormal_check_index_file_v2 (loss key)
```
@github-actions github-actions bot mentioned this pull request Aug 7, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Aug 7, 2025
@wyxxxcat
[fix](checker) Fix inverted check and test for checker (#54403)
40cc00f 
related #53876 

test:
```
[ RUN      ] CheckerTest.normal_check_index_file_v1
[ RUN      ] CheckerTest.normal_inverted_check_index_file_v1
[ RUN      ] CheckerTest.normal_check_index_file_v2
[ RUN      ] CheckerTest.normal_inverted_check_index_file_v2
[ RUN      ] CheckerTest.abnormal_check_index_file_v1 (loss key)
[ RUN      ] CheckerTest.abnormal_inverted_check_index_file_v1 (loss file)
[ RUN      ] CheckerTest.abnormal_inverted_check_index_file_v2 (loss file)
[ RUN      ] CheckerTest.abnormal_check_index_file_v2 (loss key)
```
@github-actions github-actions bot mentioned this pull request Aug 7, 2025
Merged
dataroaring pushed a commit that referenced this pull request Aug 8, 2025
@github-actions @wyxxxcat
branch-3.0: [fix](checker) Fix inverted check and test for checker #5…
98bafae 
…4403 (#54469)

Cherry-picked from #54403

Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>
morrySnow pushed a commit that referenced this pull request Aug 8, 2025
@github-actions @wyxxxcat
branch-3.1: [fix](checker) Fix inverted check and test for checker #5…
e13fade 
…4403 (#54470)

Cherry-picked from #54403

Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

+1 more reviewer

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged p0_test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wyxxxcat @Thearas @hello-stephen @gavinchou @Yukang-Lian @dataroaring @morrySnow