Skip to content

branch-3.1: [fix](checker) Fix inverted check and test for checker #54403 #54470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Aug 8, 2025
Merged

branch-3.1: [fix](checker) Fix inverted check and test for checker #54403 #54470

morrySnow merged 1 commit into from
Aug 8, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 7, 2025

Cherry-picked from #54403

@wyxxxcat
[fix](checker) Fix inverted check and test for checker (#54403)
40cc00f 
related #53876 

test:
```
[ RUN      ] CheckerTest.normal_check_index_file_v1
[ RUN      ] CheckerTest.normal_inverted_check_index_file_v1
[ RUN      ] CheckerTest.normal_check_index_file_v2
[ RUN      ] CheckerTest.normal_inverted_check_index_file_v2
[ RUN      ] CheckerTest.abnormal_check_index_file_v1 (loss key)
[ RUN      ] CheckerTest.abnormal_inverted_check_index_file_v1 (loss file)
[ RUN      ] CheckerTest.abnormal_inverted_check_index_file_v2 (loss file)
[ RUN      ] CheckerTest.abnormal_check_index_file_v2 (loss key)
```
@github-actions github-actions bot requested a review from morrySnow as a code owner August 7, 2025 15:30
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Aug 7, 2025
@dataroaring dataroaring reopened this Aug 7, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 7, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 7, 2025

Cloud UT Coverage Report

Increment line coverage 68.00% (17/25) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.12% (1212/1494)
Line Coverage 65.39% (21478/32846)
Region Coverage 66.90% (10811/16160)
Branch Coverage 56.56% (5698/10074)

@morrySnow morrySnow merged commit e13fade into branch-3.1 Aug 8, 2025
24 checks passed
@github-actions github-actions bot deleted the auto-pick-54403-branch-3.1 branch August 8, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @morrySnow @dataroaring @wyxxxcat