Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,8 @@ private LogicalProject<?> getOutputProjectByCoercion(List<Column> tableSchema, L

// add cast project
List<NamedExpression> castExprs = Lists.newArrayList();
ConnectContext connCtx = ConnectContext.get();
final boolean truncateString = connCtx == null || connCtx.getSessionVariable().enableInsertValueAutoCast;
for (int i = 0; i < tableSchema.size(); ++i) {
Column col = tableSchema.get(i);
NamedExpression expr = columnToOutput.get(col.getName());
Expand All @@ -258,7 +260,7 @@ private LogicalProject<?> getOutputProjectByCoercion(List<Column> tableSchema, L
int targetLength = ((CharacterType) targetType).getLen();
if (sourceLength == targetLength) {
castExpr = TypeCoercionUtils.castIfNotSameType(castExpr, targetType);
} else if (sourceLength > targetLength && targetLength >= 0) {
} else if (truncateString && sourceLength > targetLength && targetLength >= 0) {
castExpr = new Substring(castExpr, Literal.of(1), Literal.of(targetLength));
} else if (targetType.isStringType()) {
castExpr = new Cast(castExpr, StringType.INSTANCE);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ public class SessionVariable implements Serializable, Writable {
public static final String MAX_INSTANCE_NUM = "max_instance_num";
public static final String DML_PLAN_RETRY_TIMES = "DML_PLAN_RETRY_TIMES";
public static final String ENABLE_INSERT_STRICT = "enable_insert_strict";
public static final String ENABLE_INSERT_VALUE_AUTO_CAST = "enable_insert_value_auto_cast";
public static final String INSERT_MAX_FILTER_RATIO = "insert_max_filter_ratio";

public static final String ENABLE_SERVER_SIDE_PREPARED_STATEMENT = "enable_server_side_prepared_statement";
Expand Down Expand Up @@ -1047,6 +1048,13 @@ public enum IgnoreSplitType {
@VariableMgr.VarAttr(name = ENABLE_INSERT_STRICT, needForward = true)
public boolean enableInsertStrict = true;

@VariableMgr.VarAttr(name = ENABLE_INSERT_VALUE_AUTO_CAST, needForward = true, description = {
"INSERT VALUE 语句是否自动类型转换。当前只针对长字符串自动截短。默认开。",
"INSERT VALUE statement whether to automatically type cast. Only use for truncate long string. "
+ "ON by default."
})
public boolean enableInsertValueAutoCast = true;

@VariableMgr.VarAttr(name = INSERT_MAX_FILTER_RATIO, needForward = true)
public double insertMaxFilterRatio = 1.0;

Expand Down Expand Up @@ -3197,6 +3205,10 @@ public void setEnableInsertStrict(boolean enableInsertStrict) {
this.enableInsertStrict = enableInsertStrict;
}

public boolean getEnableInsertValueAutoCast() {
return enableInsertValueAutoCast;
}

public double getInsertMaxFilterRatio() {
return insertMaxFilterRatio;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,16 @@
3 30 3 3 3.0 2000-01-03 5 5 5 5.0 2000-01-05 5

-- !select_all_default --
true 10 10000 10000000 92233720368547758 19223372036854775807 3.142 hello world, today is 15/06/2023 2023-06-15 2023-06-15T16:10:15
true 10 10000 10000000 92233720368547758 19223372036854775807 3.14159 hello world, today is 15/06/2023 2023-06-15 2023-06-15T16:10:15

-- !mv --
-4 -4 -4 d

-- !select_test_insert_cast_interval --
1 2020-02-02

-- !select_test_insert_more_string --
1 ab
2 abcd
5 o

Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ suite('nereids_insert_into_values') {
sql 'set enable_nereids_dml=true'
sql 'set enable_strict_consistency_dml=true'

sql 'use nereids_insert_into_table_test'

def t1 = 'value_t1'
def t2 = 'value_t2'
def t3 = 'value_t3'
Expand Down Expand Up @@ -143,4 +141,54 @@ suite('nereids_insert_into_values') {
sql "insert into agg_have_dup_base_value values (-4, -4, -4, 'd')"
sql "sync"
qt_mv "select * from agg_have_dup_base_value"
}

multi_sql """
DROP TABLE IF EXISTS test_insert_cast_interval;
CREATE TABLE test_insert_cast_interval (
`id` int NULL,
`dt` date NULL
) ENGINE=OLAP
DUPLICATE KEY(`id`, `dt`)
DISTRIBUTED BY HASH(`id`) BUCKETS 10
PROPERTIES (
"replication_allocation" = "tag.location.default: 1"
);

INSERT INTO test_insert_cast_interval values(1, date_floor('2020-02-02', interval 1 second));
"""

qt_select_test_insert_cast_interval "select * from test_insert_cast_interval"

multi_sql """
drop table if exists test_insert_more_string;
CREATE TABLE test_insert_more_string (
`r_regionkey` int NULL,
`r_name` varchar(4) NULL
)
DUPLICATE KEY(`r_regionkey`)
DISTRIBUTED BY HASH(`r_regionkey`)
BUCKETS 1 PROPERTIES (
"replication_allocation" = "tag.location.default: 1"
);
"""

// shorter varchar is ok
sql "insert into test_insert_more_string values (1, 'ab')"

// set enable_insert_value_auto_cast = true
// longer varchar will truncate
sql "insert into test_insert_more_string values (2, 'abcdefg')"

// when disable string auto cast and in insert strict mode, insert will failed
sql 'set enable_insert_value_auto_cast = false'
test {
sql "insert into test_insert_more_string values (3, 'hi'), (4, 'jklmn')"
exception 'Insert has filtered data in strict mode'
}

// when disable insert strict, the longer varchar row will be filtered, other rows will succ
sql 'set enable_insert_strict = false'
sql "insert into test_insert_more_string values (5, 'o'), (6, 'pqrst')"

order_qt_select_test_insert_more_string "select * from test_insert_more_string"
}
Loading