Skip to content

Conversation

@luwei16
Copy link
Contributor

@luwei16 luwei16 commented Sep 28, 2025

No description provided.

@Thearas
Copy link
Contributor

Thearas commented Sep 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 28, 2025

run buildall

gavinchou
gavinchou previously approved these changes Sep 28, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 28, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (10/10) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (10/10) 🎉
Increment coverage report
Complete coverage report

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 29, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 29, 2025
@doris-robot
Copy link

ClickBench: Total hot run time: 30 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c91660b79a813d427b422f119a19e22ed743f2d, data reload: false

query1	0.06	0.06	0.05
query2	0.10	0.05	0.06
query3	0.25	0.09	0.09
query4	1.60	0.12	0.12
query5	0.28	0.26	0.26
query6	1.17	0.63	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.65	0.53	0.54
query10	0.58	0.58	0.57
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.62	0.62	0.62
query14	1.01	1.05	1.02
query15	0.87	0.87	0.86
query16	0.41	0.40	0.40
query17	1.04	1.04	1.04
query18	0.21	0.20	0.20
query19	2.00	1.88	1.92
query20	0.01	0.01	0.01
query21	15.49	0.95	0.57
query22	0.78	1.13	0.74
query23	14.90	1.35	0.59
query24	6.43	1.33	0.37
query25	0.48	0.08	0.12
query26	0.60	0.16	0.14
query27	0.07	0.06	0.05
query28	9.79	1.37	0.94
query29	12.55	3.94	3.22
query30	0.28	0.14	0.11
query31	2.83	0.62	0.39
query32	3.25	0.56	0.47
query33	3.16	3.06	3.11
query34	16.20	5.45	4.84
query35	4.89	4.95	4.90
query36	0.70	0.51	0.51
query37	0.11	0.08	0.07
query38	0.07	0.05	0.05
query39	0.04	0.03	0.03
query40	0.17	0.16	0.15
query41	0.08	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 104.2 s
Total hot run time: 30 s

dataroaring
dataroaring previously approved these changes Sep 29, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 29, 2025
gavinchou
gavinchou previously approved these changes Sep 29, 2025
@luwei16
Copy link
Contributor Author

luwei16 commented Sep 29, 2025

run p0

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 29, 2025

run external

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 29, 2025

run cloud_p0

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (10/10) 🎉
Increment coverage report
Complete coverage report

5 similar comments
@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (10/10) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (10/10) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (10/10) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (10/10) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (10/10) 🎉
Increment coverage report
Complete coverage report

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 30, 2025

run p0

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 30, 2025

run cloud_p0

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 50.00% (5/10) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 50.00% (5/10) 🎉
Increment coverage report
Complete coverage report

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 30, 2025

run p0

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 30, 2025

run nonConcurrent

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 30, 2025

run external

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 50.00% (5/10) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 50.00% (5/10) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 30, 2025
Copy link
Collaborator

@Hastyshell Hastyshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8e53a73 into apache:master Sep 30, 2025
27 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 30, 2025
github-actions bot pushed a commit that referenced this pull request Sep 30, 2025
yiguolei pushed a commit that referenced this pull request Sep 30, 2025
…change expr leading to schema errors #56602 (#56684)

Cherry-picked from #56602

Co-authored-by: Luwei <814383175@qq.com>
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 4, 2025
luwei16 added a commit to luwei16/Doris that referenced this pull request Oct 30, 2025
morrySnow pushed a commit that referenced this pull request Nov 5, 2025
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
…sage of schema change expr leading to schema errors apache#56602 (apache#4955)

cherry-picks from apache#56602
Related to apache#4918

---------

Co-authored-by: Luwei <814383175@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.3-merged dev/4.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants