[Feature] Support create history dynamic partition#5703
Merged
morningman merged 9 commits intoapache:masterfrom May 8, 2021
Merged
[Feature] Support create history dynamic partition#5703morningman merged 9 commits intoapache:masterfrom
morningman merged 9 commits intoapache:masterfrom
Conversation
morningman
added
area/catalog
EmmyMiao87
previously approved these changes
May 7, 2021
|
|
||
| * `dynamic_partition.create_history_partition` | ||
|
|
||
| 默认为 false。当置为 true 时，Doris 会自动创建由 start 到 end 的所有分区。同时，FE 的参数 `max_dynamic_partition_num` 会限制总分区数量，以避免一次性创建过多分区。 |
Contributor
There was a problem hiding this comment.
如果 max_dynamic_partition_num 大于 end - start 则无法创建动态分区，并且报错xxx。描述一下
| * The number is determined by "start" and "end" in the dynamic partition parameters. | ||
| */ | ||
| @ConfField(mutable = true, masterOnly = true) | ||
| public static int max_dynamic_partition_num = 500; |
EmmyMiao87
reviewed
May 8, 2021
|
|
||
| 默认为 false。当置为 true 时，Doris 会自动创建由 start 到 end 的所有分区。同时，FE 的参数 `max_dynamic_partition_num` 会限制总分区数量，以避免一次性创建过多分区。当 end - start 的值大于 `max_dynamic_partition_num` 值时，操作将被禁止。 | ||
|
|
||
| 当不指定 `start` 属性时，该参数不生效。 |
morningman
force-pushed
the
fill_histo_partition
branch
from
6a34de3 to
6823645
Compare
morningman
added a commit
to morningman/doris
that referenced
this pull request
May 8, 2021
This bug is introduced from apache#5722 Also fix a bug of creating dynamic history partitions, introduced from apache#5703
10 tasks
morningman
added a commit
that referenced
this pull request
May 10, 2021
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
May 14, 2021
1. Add a new dynamic partition property `create_history_partition`.
If set to true, Doris will create all partitions from `start` to `end`.
2. Add a new FE config `max_dynamic_partition_num`
To limit the number of partitions created when creating one table.
Change-Id: I025772a8920423824335ffdac443c73af28f0cb1
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
May 14, 2021
This bug is introduced from apache#5722 Also fix a bug of creating dynamic history partitions, introduced from apache#5703
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a new dynamic partition property
create_history_partition.If set to true, Doris will create all partitions from
starttoend.Add a new FE config
max_dynamic_partition_numTo limit the number of partitions created when creating one table.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...