[Bug-fix] Fix the replay error in stream load manager#5722
Merged
morningman merged 8 commits intoapache:masterfrom May 5, 2021
Merged
[Bug-fix] Fix the replay error in stream load manager#5722morningman merged 8 commits intoapache:masterfrom
morningman merged 8 commits intoapache:masterfrom
Conversation
EmmyMiao87
force-pushed
the
stream_load_audit
branch
from
09dc951 to
071db23
Compare
EmmyMiao87
changed the title
EmmyMiao87
added
kind/fix
caiconghui
reviewed
Apr 29, 2021
caiconghui
reviewed
Apr 29, 2021
| if (beIdToLastStreamLoad.containsKey(backend.getId())) { | ||
| long lastStreamLoadTime = beIdToLastStreamLoad.get(backend.getId()); | ||
| LOG.info("Replay stream load bdbje. backend: {}, last stream load version: {}", backend.getHost(), lastStreamLoadTime); | ||
| LOG.info("Replay stream load bdbje. backend: {}, last stream load time: {}", backend.getHost(), lastStreamLoadTime); |
Contributor
There was a problem hiding this comment.
what if disable stream load the value for lastStreamLoadTime will be?
Contributor
Author
There was a problem hiding this comment.
In fact, even if the collection process of be is disabled.
The stream load record of fe will still obtain stream load information regularly.
It’s just that every time you get it is empty.
In fact, FE can also add another variable to stop obtaining stream load record.
But there are too many variables.
To avoid using complexity.
I did not add this switch to fe.
The previous replay logic does not record the size of the map, which eventually resulted in EOF when reading the log. This pr replaces the replay logic directly with json. At the same time, the replay logic of image is supplemented. The pr ensure that the attributes 'lastStreamLoadTime' of backend can be correctly recorded in the image. Fixed apache#5729
False: disable stream load record The default is disable.
EmmyMiao87
force-pushed
the
stream_load_audit
branch
from
88735dd to
3cd0cec
Compare
morningman
added a commit
to morningman/doris
that referenced
this pull request
May 8, 2021
This bug is introduced from apache#5722 Also fix a bug of creating dynamic history partitions, introduced from apache#5703
10 tasks
morningman
added a commit
that referenced
this pull request
May 10, 2021
EmmyMiao87
added a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
May 14, 2021
The previous replay logic does not record the size of the map, which eventually resulted in EOF when reading the log. This pr replaces the replay logic directly with json. At the same time, the replay logic of image is supplemented. The pr ensure that the attributes 'lastStreamLoadTime' of backend can be correctly recorded in the image.
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
May 14, 2021
This bug is introduced from apache#5722 Also fix a bug of creating dynamic history partitions, introduced from apache#5703
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix the replay error in stream load manager
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.