Skip to content

[fix](nereids)from_unixtime support decimalv3 literal as its first argument when used in fold constant rule #57363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 3 commits into from
Nov 14, 2025
Merged

[fix](nereids)from_unixtime support decimalv3 literal as its first argument when used in fold constant rule #57363

starocean999 merged 3 commits into from
Nov 14, 2025

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Oct 27, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@starocean999
Copy link
Contributor Author

starocean999 commented Oct 27, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Oct 27, 2025

ClickBench: Total hot run time: 28.38 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a8d1c6c2308cc0db09df29bd60d6b6106d751764, data reload: false

query1	0.07	0.06	0.05
query2	0.10	0.05	0.06
query3	0.27	0.09	0.08
query4	1.61	0.12	0.11
query5	0.28	0.26	0.27
query6	1.18	0.66	0.66
query7	0.03	0.03	0.03
query8	0.06	0.05	0.06
query9	0.62	0.56	0.54
query10	0.59	0.60	0.58
query11	0.18	0.12	0.12
query12	0.16	0.13	0.13
query13	0.62	0.61	0.60
query14	1.01	1.02	1.02
query15	0.86	0.86	0.85
query16	0.41	0.41	0.41
query17	1.06	1.10	1.07
query18	0.22	0.20	0.21
query19	1.89	1.78	1.85
query20	0.02	0.02	0.02
query21	15.40	0.20	0.14
query22	5.05	0.08	0.06
query23	15.65	0.27	0.11
query24	2.84	0.63	0.67
query25	0.08	0.07	0.07
query26	0.15	0.14	0.14
query27	0.06	0.05	0.06
query28	4.78	1.19	0.95
query29	12.56	4.30	3.51
query30	0.28	0.14	0.11
query31	2.84	0.62	0.40
query32	3.25	0.58	0.49
query33	3.04	3.09	3.13
query34	15.84	5.20	4.54
query35	4.60	4.63	4.61
query36	0.70	0.52	0.50
query37	0.11	0.06	0.06
query38	0.08	0.05	0.04
query39	0.04	0.04	0.03
query40	0.18	0.14	0.14
query41	0.09	0.04	0.04
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 98.95 s
Total hot run time: 28.38 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 27, 2025

FE Regression Coverage Report

Increment line coverage 78.95% (15/19) 🎉
Increment coverage report
Complete coverage report

@wm1581066 wm1581066 added the usercase Important user case type label label Oct 27, 2025
@starocean999
Copy link
Contributor Author

starocean999 commented Oct 28, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 28, 2025

TPC-DS: Total hot run time: 190983 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4f9b79f9ce0705b2781a7e3a5012b4c166ca9c7a, data reload: false

query1	1086	448	399	399
query2	6577	1763	1712	1712
query3	6758	228	225	225
query4	27068	23953	23200	23200
query5	4964	655	502	502
query6	370	264	231	231
query7	4671	508	333	333
query8	357	268	267	267
query9	8696	2624	2633	2624
query10	504	324	287	287
query11	15872	15365	15685	15365
query12	256	136	130	130
query13	1755	626	461	461
query14	11963	9850	9800	9800
query15	266	229	198	198
query16	8097	721	530	530
query17	2415	840	698	698
query18	2217	459	367	367
query19	310	233	200	200
query20	139	136	143	136
query21	214	138	118	118
query22	4553	4627	4630	4627
query23	35023	33723	33482	33482
query24	8347	2419	2484	2419
query25	601	516	442	442
query26	1223	274	162	162
query27	2708	520	368	368
query28	4326	2232	2203	2203
query29	790	627	487	487
query30	307	224	194	194
query31	934	813	769	769
query32	78	73	69	69
query33	599	384	325	325
query34	807	867	534	534
query35	816	849	759	759
query36	969	1000	893	893
query37	124	105	87	87
query38	3570	3609	3529	3529
query39	1695	1407	1420	1407
query40	217	127	120	120
query41	62	60	59	59
query42	123	113	120	113
query43	491	487	479	479
query44	1273	761	741	741
query45	182	178	173	173
query46	905	1003	651	651
query47	1764	1798	1725	1725
query48	395	435	326	326
query49	767	520	432	432
query50	674	705	427	427
query51	3904	3877	3861	3861
query52	120	107	113	107
query53	248	276	201	201
query54	617	608	540	540
query55	89	88	87	87
query56	323	313	322	313
query57	1163	1180	1108	1108
query58	299	282	281	281
query59	2531	2633	2467	2467
query60	365	353	327	327
query61	161	175	166	166
query62	804	736	668	668
query63	241	201	198	198
query64	4475	1218	886	886
query65	4039	3963	4008	3963
query66	1087	443	335	335
query67	15295	15331	14887	14887
query68	8985	940	614	614
query69	474	340	299	299
query70	1380	1241	1331	1241
query71	482	348	334	334
query72	5610	4865	4938	4865
query73	559	604	360	360
query74	8991	8923	8942	8923
query75	4178	3395	2829	2829
query76	3284	1171	764	764
query77	935	428	321	321
query78	9526	9847	9008	9008
query79	1726	856	599	599
query80	742	597	539	539
query81	494	270	229	229
query82	434	165	134	134
query83	295	287	255	255
query84	315	119	102	102
query85	913	497	430	430
query86	338	334	322	322
query87	3812	3769	3687	3687
query88	2923	2270	2269	2269
query89	393	334	298	298
query90	2004	215	222	215
query91	171	189	138	138
query92	92	70	67	67
query93	1173	979	652	652
query94	693	436	345	345
query95	412	331	309	309
query96	500	574	287	287
query97	2970	2986	2867	2867
query98	230	212	211	211
query99	1454	1413	1290	1290
Total cold run time: 281127 ms
Total hot run time: 190983 ms

@doris-robot
Copy link

doris-robot commented Oct 28, 2025

ClickBench: Total hot run time: 27.69 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4f9b79f9ce0705b2781a7e3a5012b4c166ca9c7a, data reload: false

query1	0.06	0.05	0.06
query2	0.09	0.06	0.06
query3	0.26	0.09	0.08
query4	1.61	0.12	0.11
query5	0.29	0.27	0.27
query6	1.16	0.66	0.65
query7	0.03	0.03	0.03
query8	0.05	0.04	0.05
query9	0.61	0.54	0.52
query10	0.59	0.57	0.57
query11	0.16	0.12	0.11
query12	0.15	0.13	0.14
query13	0.62	0.60	0.61
query14	1.01	1.03	1.01
query15	0.86	0.86	0.86
query16	0.39	0.39	0.40
query17	1.02	1.03	1.04
query18	0.22	0.20	0.20
query19	1.89	1.81	1.87
query20	0.02	0.01	0.02
query21	15.44	0.19	0.12
query22	5.13	0.06	0.05
query23	15.81	0.27	0.10
query24	3.23	0.50	0.44
query25	0.07	0.06	0.05
query26	0.14	0.13	0.13
query27	0.06	0.05	0.05
query28	4.30	1.14	0.95
query29	12.61	3.97	3.27
query30	0.29	0.14	0.12
query31	2.82	0.59	0.39
query32	3.23	0.55	0.48
query33	3.06	3.03	3.05
query34	15.61	5.10	4.57
query35	4.60	4.55	4.58
query36	0.68	0.51	0.50
query37	0.10	0.06	0.06
query38	0.07	0.04	0.04
query39	0.04	0.04	0.04
query40	0.18	0.14	0.13
query41	0.08	0.03	0.03
query42	0.05	0.03	0.04
query43	0.04	0.04	0.03
Total cold run time: 98.73 s
Total hot run time: 27.69 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 28, 2025

FE Regression Coverage Report

Increment line coverage 33.33% (8/24) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 29, 2025

FE Regression Coverage Report

Increment line coverage 12.50% (3/24) 🎉
Increment coverage report
Complete coverage report

@starocean999 starocean999 marked this pull request as ready for review October 29, 2025 08:09
@starocean999
Copy link
Contributor Author

starocean999 commented Oct 31, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 31, 2025

TPC-DS: Total hot run time: 187965 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 073da597377ec71686b26dac8526c4845fb888af, data reload: false

query1	1022	433	415	415
query2	6572	1653	1694	1653
query3	6751	240	216	216
query4	26424	23425	23428	23425
query5	4966	635	475	475
query6	336	238	217	217
query7	4665	501	299	299
query8	302	269	263	263
query9	8734	2563	2590	2563
query10	549	354	299	299
query11	15647	15512	14937	14937
query12	189	115	113	113
query13	1667	558	446	446
query14	12043	9292	9442	9292
query15	213	190	175	175
query16	7651	666	498	498
query17	1376	742	613	613
query18	2073	459	398	398
query19	223	227	197	197
query20	140	130	134	130
query21	226	147	135	135
query22	4812	4846	4674	4674
query23	34991	33593	33659	33593
query24	8754	2544	2529	2529
query25	650	553	484	484
query26	1263	287	177	177
query27	2723	542	397	397
query28	5717	2228	2246	2228
query29	857	649	499	499
query30	302	233	202	202
query31	942	861	759	759
query32	93	77	77	77
query33	893	428	354	354
query34	1349	867	561	561
query35	849	834	785	785
query36	989	1032	931	931
query37	132	117	112	112
query38	3857	3651	3625	3625
query39	1486	1439	1458	1439
query40	222	124	121	121
query41	59	58	59	58
query42	123	114	111	111
query43	499	488	465	465
query44	1235	744	731	731
query45	186	177	170	170
query46	894	994	649	649
query47	1723	1791	1709	1709
query48	400	439	313	313
query49	766	484	409	409
query50	657	703	405	405
query51	3864	3902	3823	3823
query52	110	107	97	97
query53	248	268	201	201
query54	305	305	278	278
query55	84	87	82	82
query56	316	300	326	300
query57	1177	1188	1092	1092
query58	289	271	274	271
query59	2539	2731	2512	2512
query60	343	328	317	317
query61	160	161	160	160
query62	808	742	671	671
query63	240	196	196	196
query64	4533	1287	958	958
query65	4043	3951	3948	3948
query66	1101	476	352	352
query67	15451	15088	14949	14949
query68	7619	884	605	605
query69	472	322	291	291
query70	1372	1289	1209	1209
query71	421	350	313	313
query72	6175	2867	5328	2867
query73	627	771	366	366
query74	8892	9143	8704	8704
query75	3318	3374	2865	2865
query76	2776	1182	763	763
query77	601	423	307	307
query78	9683	9744	8913	8913
query79	2811	829	603	603
query80	671	577	494	494
query81	515	260	228	228
query82	225	161	133	133
query83	262	269	245	245
query84	262	110	95	95
query85	920	484	453	453
query86	385	304	310	304
query87	3626	3699	3693	3693
query88	4375	2266	2274	2266
query89	404	325	300	300
query90	2023	219	222	219
query91	164	167	137	137
query92	76	67	69	67
query93	2457	988	642	642
query94	701	446	338	338
query95	411	328	315	315
query96	503	580	282	282
query97	2912	2983	2891	2891
query98	249	213	209	209
query99	1365	1426	1315	1315
Total cold run time: 282076 ms
Total hot run time: 187965 ms

@doris-robot
Copy link

doris-robot commented Oct 31, 2025

ClickBench: Total hot run time: 27.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 073da597377ec71686b26dac8526c4845fb888af, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.06	0.05
query3	0.26	0.08	0.08
query4	1.60	0.11	0.12
query5	0.27	0.25	0.25
query6	1.15	0.64	0.64
query7	0.04	0.02	0.03
query8	0.05	0.04	0.04
query9	0.60	0.52	0.52
query10	0.58	0.58	0.57
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	1.01	1.00	1.00
query15	0.84	0.82	0.84
query16	0.40	0.42	0.40
query17	1.06	1.02	1.02
query18	0.22	0.20	0.23
query19	1.91	1.80	1.78
query20	0.02	0.01	0.01
query21	15.46	0.19	0.13
query22	5.03	0.06	0.05
query23	15.68	0.27	0.10
query24	3.15	0.65	0.43
query25	0.08	0.07	0.05
query26	0.14	0.13	0.14
query27	0.06	0.06	0.05
query28	4.21	1.12	0.93
query29	12.54	4.02	3.23
query30	0.27	0.13	0.12
query31	2.82	0.60	0.37
query32	3.28	0.57	0.48
query33	3.02	3.03	3.06
query34	15.86	5.14	4.58
query35	4.55	4.55	4.63
query36	0.67	0.49	0.49
query37	0.09	0.06	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.04
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 98.43 s
Total hot run time: 27.45 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 31, 2025

FE Regression Coverage Report

Increment line coverage 66.67% (8/12) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 31, 2025

FE Regression Coverage Report

Increment line coverage 66.67% (8/12) 🎉
Increment coverage report
Complete coverage report

@starocean999 starocean999 mentioned this pull request Nov 3, 2025
Merged
morrySnow pushed a commit that referenced this pull request Nov 10, 2025
@starocean999
branch-3.1: [fix](nereids)fold constant rule can't fold from_unixtime…
b752bdc 
… when its 1st param is decimalv3 literal #57363 (#57606)

picked from #57363
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

PR approved by anyone and no changes requested.

@starocean999 starocean999 changed the title [fix](nereids)fold constant rule can't fold from_unixtime when its 1st param is decimalv3 literal [fix](nereids)from_unixtime support decimalv3 literal as its first argument when used in fold constant rule Nov 14, 2025
@starocean999 starocean999 merged commit 2350f61 into apache:master Nov 14, 2025
30 of 31 checks passed
starocean999 added a commit to starocean999/incubator-doris that referenced this pull request Nov 27, 2025
@starocean999
branch-4.0: [fix](nereids)fold constant rule can't fold from_unixtime…
d1fd745 
… when its 1st param is decimalv3 literal apache#57363
@starocean999 starocean999 mentioned this pull request Nov 27, 2025
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Nov 28, 2025
@starocean999
branch-4.0: [fix](nereids)fold constant rule can't fold from_unixtime…
a879ecd 
… when its 1st param is decimalv3 literal #57363 (#58454)

pick #57363

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@starocean999 @nagisa-kunhah
[fix](nereids)from_unixtime support decimalv3 literal as its first ar…
8680b76 
…gument when used in fold constant rule (apache#57363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.3-merged dev/4.0.2-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@starocean999 @hello-stephen @doris-robot @englefly @zhangstar333 @yiguolei @wm1581066 @morrySnow