Skip to content

branch-3.1: [fix](nereids)fold constant rule can't fold from_unixtime when its 1st param is decimalv3 literal #57363 #57606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 4 commits into from
Nov 10, 2025
Merged

branch-3.1: [fix](nereids)fold constant rule can't fold from_unixtime when its 1st param is decimalv3 literal #57363 #57606

morrySnow merged 4 commits into from
Nov 10, 2025

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Nov 3, 2025 •
edited by morrySnow
Loading

picked from #57363

@Thearas
Copy link
Contributor

Thearas commented Nov 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor Author

starocean999 commented Nov 3, 2025

run buildall

@starocean999
Copy link
Contributor Author

starocean999 commented Nov 4, 2025

run buildall

1 similar comment
@starocean999
Copy link
Contributor Author

starocean999 commented Nov 4, 2025

run buildall

@starocean999 starocean999 marked this pull request as ready for review November 5, 2025 02:24
@starocean999
Copy link
Contributor Author

starocean999 commented Nov 7, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 7, 2025

FE UT Coverage Report

Increment line coverage 16.00% (4/25) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow changed the title [fix](nereids)fold constant rule can't fold from_unixtime when its 1st param is decimalv3 literal branch-3.1: [fix](nereids)fold constant rule can't fold from_unixtime when its 1st param is decimalv3 literal #57363 Nov 10, 2025
@morrySnow morrySnow merged commit b752bdc into apache:branch-3.1 Nov 10, 2025
24 checks passed
@morrySnow morrySnow mentioned this pull request Nov 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@starocean999 @Thearas @hello-stephen @morrySnow