[fix](parser) Fix FROM DUAL incorrectly matching table names starting with dual #59003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
feiniaofeiafei
approved these changes
Dec 12, 2025
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
FE Regression Coverage ReportIncrement line coverage |
morningman
approved these changes
Dec 14, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 14, 2025
… with dual (#59003) The lexer rule `FROM_DUAL` was matching `FROM dualtbl` as `FROM DUAL` + `tbl`, causing parse errors when using table/CTE names starting with 'dual'. Move DUAL handling from lexer to parser level - Remove `FROM_DUAL` lexer rule - Add `#fromDual` branch in `fromClause` parser rule - Handle `FromDualContext` in LogicalPlanBuilder
Contributor
FE Regression Coverage ReportIncrement line coverage |
nagisa-kunhah
pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
… with dual (apache#59003) The lexer rule `FROM_DUAL` was matching `FROM dualtbl` as `FROM DUAL` + `tbl`, causing parse errors when using table/CTE names starting with 'dual'. Move DUAL handling from lexer to parser level - Remove `FROM_DUAL` lexer rule - Add `#fromDual` branch in `fromClause` parser rule - Handle `FromDualContext` in LogicalPlanBuilder
yiguolei
pushed a commit
that referenced
this pull request
Dec 16, 2025
… with dual (#59003) The lexer rule `FROM_DUAL` was matching `FROM dualtbl` as `FROM DUAL` + `tbl`, causing parse errors when using table/CTE names starting with 'dual'. Move DUAL handling from lexer to parser level - Remove `FROM_DUAL` lexer rule - Add `#fromDual` branch in `fromClause` parser rule - Handle `FromDualContext` in LogicalPlanBuilder
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Dec 18, 2025
… with dual (apache#59003) The lexer rule `FROM_DUAL` was matching `FROM dualtbl` as `FROM DUAL` + `tbl`, causing parse errors when using table/CTE names starting with 'dual'. Move DUAL handling from lexer to parser level - Remove `FROM_DUAL` lexer rule - Add `#fromDual` branch in `fromClause` parser rule - Handle `FromDualContext` in LogicalPlanBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lexer rule
FROM_DUALwas matchingFROM dualtblasFROM DUAL+tbl,causing parse errors when using table/CTE names starting with 'dual'.
Move DUAL handling from lexer to parser level
FROM_DUALlexer rule#fromDualbranch infromClauseparser ruleFromDualContextin LogicalPlanBuilder