Skip to content

branch-4.0: [fix](parser) Fix FROM DUAL incorrectly matching table names starting with dual #59003 #59021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Dec 17, 2025
Merged

branch-4.0: [fix](parser) Fix FROM DUAL incorrectly matching table names starting with dual #59003 #59021

yiguolei merged 1 commit into from
Dec 17, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 14, 2025

Cherry-picked from #59003

@github-actions github-actions bot requested a review from yiguolei as a code owner December 14, 2025 15:03
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 14, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 14, 2025

run buildall

@zy-kkk @yiguolei
[fix](parser) Fix FROM DUAL incorrectly matching table names starting…
5b92835 
… with dual (#59003)

The lexer rule `FROM_DUAL` was matching `FROM dualtbl` as `FROM DUAL` +
`tbl`,
  causing parse errors when using table/CTE names starting with 'dual'.

  Move DUAL handling from lexer to parser level

  - Remove `FROM_DUAL` lexer rule
  - Add `#fromDual` branch in `fromClause` parser rule
  - Handle `FromDualContext` in LogicalPlanBuilder
@yiguolei yiguolei force-pushed the auto-pick-59003-branch-4.0 branch from 8ed888d to 5b92835 Compare December 16, 2025 06:20
@yiguolei
Copy link
Contributor

yiguolei commented Dec 16, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 16, 2025

FE UT Coverage Report

Increment line coverage 75.00% (3/4) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 17, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 17, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 17, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 6cd317a into branch-4.0 Dec 17, 2025
24 of 29 checks passed
@github-actions github-actions bot deleted the auto-pick-59003-branch-4.0 branch December 17, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @yiguolei @dataroaring @zy-kkk