[fix](agg) Fix grouping function handling and repeatSlotIdList calculation in DecomposeRepeatWithPreAggregation #60091
+466
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31857 ms |
TPC-DS: Total hot run time: 174145 ms |
ClickBench: Total hot run time: 26.84 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
…sions that only exist in the largest grouping set
…ts slots sets return 1 when compute value
feiniaofeiafei
force-pushed
the
fix_repeat_rewrite
branch
from
ae3ef77 to
43a9454
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 30728 ms |
TPC-DS: Total hot run time: 173968 ms |
ClickBench: Total hot run time: 26.83 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 30939 ms |
TPC-DS: Total hot run time: 173439 ms |
ClickBench: Total hot run time: 27.16 s |
Contributor
Author
|
run cloud_p0 |
Contributor
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
feiniaofeiafei
changed the title
TPC-H: Total hot run time: 32310 ms |
ClickBench: Total hot run time: 28.57 s |
Contributor
Author
|
run p0 |
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run feut |
Contributor
Author
|
run p0 |
Contributor
Author
|
run cloud_p0 |
Contributor
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE Regression Coverage ReportIncrement line coverage |
morrySnow
reviewed
Jan 28, 2026
| * This is necessary for optimization scenarios where some expressions may only exist | ||
| * in the maximum grouping set that was removed during optimization. | ||
| */ | ||
| default GroupingSetShapes toShapes() { |
Contributor
There was a problem hiding this comment.
add a ut for this function
| */ | ||
| default List<Set<Integer>> computeRepeatSlotIdList(List<Integer> slotIdList) { | ||
| List<Set<Integer>> groupingSetsIndexesInOutput = getGroupingSetsIndexesInOutput(); | ||
| default List<Set<Integer>> computeRepeatSlotIdList(List<Integer> slotIdList, List<Slot> outputSlots) { |
Contributor
There was a problem hiding this comment.
add a ut for this function
| */ | ||
| default List<Set<Integer>> getGroupingSetsIndexesInOutput() { | ||
| Map<Expression, Integer> indexMap = indexesOfOutput(); | ||
| default List<Set<Integer>> getGroupingSetsIndexesInOutput(List<Slot> outputSlots) { |
Contributor
There was a problem hiding this comment.
add a ut for this function
| * ) | ||
| */ | ||
| default Map<Expression, Integer> indexesOfOutput() { | ||
| default Map<Expression, Integer> indexesOfOutput(List<Slot> outputSlots) { |
Contributor
There was a problem hiding this comment.
add a ut for this function
| } | ||
|
|
||
| public Set<GroupingScalarFunction> getGroupingScalarFunctions() { | ||
| return new HashSet<>( |
| */ | ||
| default GroupingSetShapes toShapes() { | ||
| Set<Expression> flattenGroupingSet = ImmutableSet.copyOf(ExpressionUtils.flatExpressions(getGroupingSets())); | ||
| Set<Expression> flattenGroupingSet = ImmutableSet.copyOf(getGroupByExpressions()); |
Contributor
There was a problem hiding this comment.
if flattenGroupingSet only used in L138 to construct allExpresssions, why copy twice in this function?
| * ) | ||
| */ | ||
| default Map<Expression, Integer> indexesOfOutput() { | ||
| default Map<Expression, Integer> indexesOfOutput(List<Slot> outputSlots) { |
Contributor
There was a problem hiding this comment.
should add comment to explain why need pass outputSlots, not use outputExpression
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32104 ms |
ClickBench: Total hot run time: 28.33 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #59116 #60045
Problem Summary:
There are 2 problems:
DecomposeRepeatWithPreAggregationoptimization removes the maximum grouping set, grouping functions (e.g.,grouping(),grouping_id()) that reference expressions only existing in the removed grouping set would fail because of index lookup failure: When computing grouping function values,GroupingSetShapes.indexOf()would return -1 for expressions not inflattenGroupingSetExpression, causing incorrect behavior.Example scenario:
After optimization removes the maximum grouping set
(a, b, c), the expressioncno longer exists in the remaining grouping sets. When computinggrouping(c), the index lookup would fail.2. The
repeatSlotIdListcalculation was incorrect because it relied on the assumption that the order ofphysicalRepeat.getOutputExpressions()matches the order ofoutputTuple. However, this assumption can be broken during rule rewriting (e.g., inDecomposeRepeatWithPreAggregation.constructRepeat()at line 502-503, wherereplacedRepeatOutputsis constructed bynew ArrayList<>(child.getOutput())and then appends grouping functions, potentially changing the order). This mismatch causes incorrect slot ID mapping and wrong query results.Example scenario:
When
DecomposeRepeatWithPreAggregationrewrites a repeat plan, the output expressions order may differ from the output tuple order, leading to incorrect slot ID mapping inrepeatSlotIdList.Solution:
Repeat.toShapes()method to ensure all expressions referenced by grouping functions are included inflattenGroupingSetExpression, even if they are not in any grouping set. For expressions that only exist in the removed maximum grouping set, they are correctly marked asshouldBeErasedToNull = truein all remaining grouping sets, which is the correct SQL semantics.Key changes:
Repeat.toShapes(): Enhanced to collect all expressions referenced by grouping functions usingExpressionUtils.collectToList()and merge them intoflattenGroupingSetExpressionshouldBeErasedToNull = truein allGroupingSetShapeinstancesGroupingSetShapes.indexOf()always returns a valid index for grouping function arguments, preventing index lookup failuresRepeat.computeRepeatSlotIdList()method to accept an additionaloutputSlotsparameter. Instead of relying on the order ofoutputExpressionsmatchingoutputTuple, the method now usesoutputSlotsto correctly map grouping set expressions to their indices in the output tuple. This ensures correct slot ID calculation even when rule rewriting changes the order of output expressions.Key changes:
computeRepeatSlotIdList(List<Integer> slotIdList, List<Slot> outputSlots): AddedoutputSlotsparametergetGroupingSetsIndexesInOutput(List<Slot> outputSlots): Modified to useoutputSlotsinstead ofgetOutputExpressions()indexesOfOutput(List<Slot> outputSlots): Modified to build index map fromoutputSlotsinstead ofgetOutputExpressions()PhysicalPlanTranslator.visitPhysicalRepeat(): Updated to passoutputSlotstocomputeRepeatSlotIdList()Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)