Skip to content

[Feature] ADD: show create routine load#6067

Closed
stalary wants to merge 21 commits intoapache:masterfrom
stalary:show_create_routine_load
Closed

[Feature] ADD: show create routine load#6067
stalary wants to merge 21 commits intoapache:masterfrom
stalary:show_create_routine_load

Conversation

@stalary
Copy link
Contributor

@stalary stalary commented Jun 21, 2021

Proposed changes

Add show create routine load

Fixed #5645

@stalary
Copy link
Contributor Author

stalary commented Jun 21, 2021

#5645

@stalary stalary changed the title [WIP] ADD: show create routine load [Feature] ADD: show create routine load Jun 21, 2021
@EmmyMiao87
Copy link
Contributor

In fact, these information will be displayed in the results of show routine load.
Under what circumstances will a show create routine load syntax be needed?

@EmmyMiao87 EmmyMiao87 self-assigned this Jun 23, 2021
@morningman
Copy link
Contributor

In fact, these information will be displayed in the results of show routine load.
Under what circumstances will a show create routine load syntax be needed?

Just like show create table, user may may need to create routine load job again.

@stalary
Copy link
Contributor Author

stalary commented Jun 23, 2021

For example, I stopped it and then tried to restart it

@EmmyMiao87
Copy link
Contributor

You need to consider a question.
Whether the routine load after stopping also needs to be displayed.

The routine load after stopping may have the same name.
So if show, it may produce multiple results.
The one way is that using 'show create routine load' to display running routine load, using 'show all create routine load' to displays all routine loads with the same name include stopped.

@EmmyMiao87 EmmyMiao87 added area/routine load kind/feature Categorizes issue or PR as related to a new feature. labels Jun 23, 2021
@stalary
Copy link
Contributor Author

stalary commented Jun 23, 2021

You need to consider a question.
Whether the routine load after stopping also needs to be displayed.

The routine load after stopping may have the same name.
So if show, it may produce multiple results.
The one way is that using 'show create routine load' to display running routine load, using 'show all create routine load' to displays all routine loads with the same name include stopped.

Well, I've decided to support both

@EmmyMiao87
Copy link
Contributor

At the moment my requirement is just to show running, do we need to support all of them?Show all create routine load is not very useful to me right now.

This is no problem.
It needs to be stated on the document that only the routine load of running or paused is displayed.

@stalary
Copy link
Contributor Author

stalary commented Jun 25, 2021

PTAL @EmmyMiao87


# SHOW CREATE ROUTINE LOAD
## description
该语句用于展示用户自定义例行导入作业的创建语句
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
该语句用于展示用户自定义例行导入作业的创建语句
该语句用于展示例行导入作业的创建语句

dbName,
tableName,
PrivPredicate.LOAD)) {
ErrorReport.reportAnalysisException(ErrorCode.ERR_TABLEACCESS_DENIED_ERROR, "LOAD",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If user don’t have permission, we can simply not display it without reporting an error

@EmmyMiao87
Copy link
Contributor

EmmyMiao87 commented Jun 28, 2021

  1. Please add some UT~
  2. Maybe you need to rebase master so that P0(NewDorisTest) could be passed.

morningman and others added 7 commits June 28, 2021 22:43
* [Enhance] Support show unrecoverable tablets

The unrecoverable tablets are tablets which non of their replicas are healthy.
We should be able to find out these tablets then manual intervention.

And these tablets should not be added to the tablet scheduler.
…information (apache#5947)

* Record all backup jobs and support where clause
Co-authored-by: zouxinyi <zouxinyi@baidu.com>
1. Disable libhdfs3 on ARM, because it doesn't support ARM now.
2. Add compilation doc for ARM64
apache#6054)

1. check the parquet schema property on FE side.
2. auto generate parquet schema if not specified.
@stalary stalary closed this Jun 28, 2021
@stalary stalary deleted the show_create_routine_load branch June 28, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/routine load kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add show create routine load support

6 participants