[MemerySave] Change TabletSchema in tablet to reference to save mem#6814
Merged
morningman merged 1 commit intoapache:masterfrom Oct 16, 2021
Merged
[MemerySave] Change TabletSchema in tablet to reference to save mem#6814morningman merged 1 commit intoapache:masterfrom
morningman merged 1 commit intoapache:masterfrom
Conversation
morningman
reviewed
Oct 12, 2021
be/src/olap/tablet_meta.cpp
Outdated
| const std::unordered_map<uint32_t, uint32_t>& col_ordinal_to_unique_id, | ||
| TabletUid tablet_uid, TTabletType::type tabletType) | ||
| : _tablet_uid(0, 0), _preferred_rowset_type(ALPHA_ROWSET) { | ||
| : _tablet_uid(0, 0), _preferred_rowset_type(ALPHA_ROWSET), _schema(new TabletSchema) { |
Contributor
There was a problem hiding this comment.
Suggested change
| : _tablet_uid(0, 0), _preferred_rowset_type(ALPHA_ROWSET), _schema(new TabletSchema) { | |
| : _tablet_uid(0, 0), _preferred_rowset_type(BETA_ROWSET), _schema(new TabletSchema) { |
| init_from_pb(tablet_meta_pb); | ||
| } | ||
|
|
||
| TabletMeta::TabletMeta(const TabletMeta& b) |
Contributor
There was a problem hiding this comment.
This may be error prone?
If I add some other fields in tablet meta and forget to modify here?
3 tasks
github-actions
bot
added
the
approved
morningman
added
area/memory-consumption
and removed
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
pushed a commit
that referenced
this pull request
Oct 19, 2021
…6814) Change TabletSchema in tablet to reference to save memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change TabletSchema in tablet to reference to save mem
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...