[branch-1.2](bug) Fix revise tablet causes replica_id is 0 in tablet meta in version 1.2#25728
Merged
lide-reed merged 2 commits intoapache:branch-1.2-ltsfrom Oct 25, 2023
Merged
Conversation
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Dec 11, 2023
…meta in version 1.2 (apache#25728)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
How to reproduce: #25864
In version 1.2, We have found a lot of tablets with replica_id which is 0 in its tablet meta, just like:
And I found that all these tablets was cloned from other backends.
Here is why:
In #6814, it use copy constructor
TabletMeta::TabletMeta(const TabletMeta& b)inrevise_tablet_metamethod.And in #9971, it introduce
replica_idinto tablet meta, but forgot to updateTabletMeta::TabletMeta(const TabletMeta& b)to setreplica_idSo clone task which call
revise_tablet_metamay causereplica_idin tablet meta to 0.When Fe submit a drop tablet task to Be, we will find a lot of WARNING LOG like:
This is because the
replica_idin tablet meta is already set to 0.Besides, in master branch, the
TabletMeta::TabletMeta(const TabletMeta& b)is not used any more.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...