[Bugfix] Fix the bug data balance causes tablet loss#9971
Merged
morningman merged 7 commits intoapache:masterfrom Jun 15, 2022
Merged
[Bugfix] Fix the bug data balance causes tablet loss#9971morningman merged 7 commits intoapache:masterfrom
morningman merged 7 commits intoapache:masterfrom
Conversation
platoneko
changed the title
morningman
reviewed
Jun 9, 2022
| * It's used to test the reliability in single replica case when tablet scheduling are frequent. | ||
| * Default is false. | ||
| */ | ||
| @ConfField |
Contributor
There was a problem hiding this comment.
Suggested change
| @ConfField | |
| @ConfField(mutable = false, masterOnly = true) |
Contributor
There was a problem hiding this comment.
And please add comment to explain more about how this works.
be/src/olap/tablet_manager.cpp
Outdated
| } | ||
| if (to_drop_tablet->replica_id() != replica_id && replica_id != 0) { | ||
| LOG(WARNING) << "fail to drop tablet because replica_id not match. " | ||
| << "tablet_id=" << tablet_id; |
Contributor
There was a problem hiding this comment.
print replica_id as well.
platoneko
force-pushed
the
rebalance-fuzzy-test
branch
from
ae953f6 to
a4e3ca5
Compare
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
qidaye
reviewed
Jun 11, 2022
Contributor
There was a problem hiding this comment.
-
In the process of cloning a tablet, when the source tablet snapshot file is downloaded, you need to reset the replica ID in the tablet meta to mark the tablet as a new tablet.
Otherwise, the drop task will still delete the tablet after the clone is finished, which is exactly the bug. -
Also need add replica id in report replica info task.
Contributor
Author
|
platoneko
force-pushed
the
rebalance-fuzzy-test
branch
from
a4e3ca5 to
e5802c2
Compare
github-actions
bot
removed
the
approved
platoneko
force-pushed
the
rebalance-fuzzy-test
branch
from
e5802c2 to
d5bea88
Compare
platoneko
force-pushed
the
rebalance-fuzzy-test
branch
from
d5bea88 to
8f39c81
Compare
platoneko
force-pushed
the
rebalance-fuzzy-test
branch
from
8f39c81 to
65c8c27
Compare
morningman
approved these changes
Jun 15, 2022
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
10 tasks
morningman
added
dev/backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #6061
Problem Summary:
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...