Skip to content

Conversation

@caiconghui
Copy link
Contributor

Proposed changes

Issue Number: close #7875

Problem Summary:

Make RewriteDateLiteralRule to be compatible with mysql

Checklist(Required)

  1. Does it affect the original behavior: (Yes)
  2. Has unit tests been added: (Yes)
  3. Has document been added or modified: (No)
  4. Does it need to update dependencies: (No)
  5. Are there any changes that cannot be rolled back: (No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@caiconghui
Copy link
Contributor Author

cc @morningman @xinghuayu007

Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 added area/mysql-compatibility Issues or PRs related to the mysql compatibility kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/improvement labels Jan 26, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 26, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@caiconghui caiconghui merged commit d2386dd into apache:master Jan 27, 2022
@EmmyMiao87 EmmyMiao87 self-assigned this Jan 27, 2022
caiconghui added a commit that referenced this pull request Jan 29, 2022
…t instead of admin (#7914)

* [improvement](show) Support that user can use show data skew statement instead of admin
This PR mainly do two things:
1. Support that user can use show data skew statement instead of admin
2. Fix fe ut failed caused by pr [improvement](rewrite) Make RewriteDateLiteralRule to be compatible with mysql #7876 and pr [feature-wip](iceberg) Step1: Support create Iceberg external table #7391

Co-authored-by: caiconghui1 <caiconghui1@jd.com>
@caiconghui caiconghui deleted the invalid_date branch March 12, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/mysql-compatibility Issues or PRs related to the mysql compatibility kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/improvement reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] DateTime Cast should be compatible with Mysql

2 participants