Skip to content

Conversation

@caiconghui
Copy link
Contributor

@caiconghui caiconghui commented Jan 27, 2022

Proposed changes

Issue Number: close #7913

Problem Summary:

This PR mainly do two things:

  1. Support that user can use show data skew statement instead of admin
  2. Fix fe ut failed caused by pr [improvement](rewrite) Make RewriteDateLiteralRule to be compatible with mysql #7876
  3. Fix fe ut failed caused by pr [feature-wip](iceberg) Step1: Support create Iceberg external table #7391

Checklist(Required)

  1. Does it affect the original behavior: (Yes)
  2. Has unit tests been added: (No)
  3. Has document been added or modified: (Yes)
  4. Does it need to update dependencies: (No)
  5. Are there any changes that cannot be rolled back: (No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@caiconghui
Copy link
Contributor Author

caiconghui commented Jan 27, 2022

ut failed cc @EmmyMiao87 show data skew cc @morningman cc @qidaye

for (int i = 0; i < tabletIds.size(); i++) {
Tablet tablet = mIndex.getTablet(tabletIds.get(i));
long dataSize = tablet.getDataSize(false);
long dataSize = tablet.getDataSize(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe single replica is better ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now,just according to the average data size column,here should compute average data size

@EmmyMiao87
Copy link
Contributor

The document could not be built correctly

@EmmyMiao87 EmmyMiao87 added kind/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/show stmt labels Jan 27, 2022
@EmmyMiao87 EmmyMiao87 self-assigned this Jan 27, 2022
"SHOW CREATE FUNCTION",
"SHOW CREATE ROUTINE LOAD",
"SHOW DATA",
"SHOW DATA SKEW",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name must be same as the name of document ~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 28, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@caiconghui caiconghui merged commit 4c7525c into apache:master Jan 29, 2022
@caiconghui caiconghui deleted the show_data_skew branch March 12, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/show stmt kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Support that user can use show data skew statement instead of admin

3 participants