[feature-wip](iceberg) Step2: add table creation strict mode and support refresh iceberg table or db. #7981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2022 14:55
…ort refresh iceberg table or db.
Change-Id: I75f8d54db9bd3729d0b67c80b53cc22ee90bc65b
morningman
reviewed
Feb 9, 2022
| Map<String, String> dbProperties = db.getDbProperties().getProperties(); | ||
| // build iceberg properties | ||
| db.getDbProperties().addAndBuildProperties(dbProperties); | ||
| // 1. check database type |
Contributor
There was a problem hiding this comment.
Why calling addAndBuildProperties here?
|
|
||
| // 2. drop database | ||
| DropDbStmt dropDbStmt = new DropDbStmt(true, dbName, true); | ||
| catalog.dropDb(dropDbStmt); |
Contributor
There was a problem hiding this comment.
There may be other type of tables in this database. If you drop it, all other tables will lost.
morningman
added
area/iceberg
kind/feature
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #7980
Problem Summary:
iceberg_table_creation_strict_modeinfe.confto control iceberg external table creation, when data type is not supported in Doris.REFRESHsyntax to synchronize the Iceberg table and database.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...