[chore] Fix memory problems in agg_test.cpp. #8019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
A simpler solution is just add delete at end of function. if (place != nullptr) {
delete[] place;
} |
Contributor
Author
|
@BiteTheDDDDt Yes, but I want to follow the principle of RAII in modern C++ to avoid call |
Contributor
|
LGTM |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
hi @adonis0147 , please rebase the master to resolve the conflict |
github-actions
bot
removed
the
approved
Contributor
Author
|
Hi @morningman, I have rebased the master branch. |
morningman
approved these changes
Feb 14, 2022
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #8018 .
Problem Summary:
Please refer to #8018 .
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...