Skip to content

[chore] Fix memory problems in agg_test.cpp. #8019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
Feb 14, 2022
Merged

[chore] Fix memory problems in agg_test.cpp. #8019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3197766
[chore] Fix memory problems in agg_test.cpp.
adonis0147 Feb 11, 2022
b7ff7c9
Simplify the modification.
adonis0147 Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions be/test/vec/aggregate_functions/agg_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.

#include <memory>
#include <string>

#include "gtest/gtest.h"
Expand Down Expand Up @@ -45,7 +46,8 @@ TEST(AggTest, basic_test) {
DataTypes data_types = {data_type};
Array array;
auto agg_function = factory.get("sum", data_types, array);
AggregateDataPtr place = new char[agg_function->size_of_data()];
std::unique_ptr<char[]> memory(new char[agg_function->size_of_data()]);
AggregateDataPtr place = memory.get();
agg_function->create(place);
const IColumn* column[1] = {column_vector_int32.get()};
for (int i = 0; i < agg_test_batch_size; i++) {
Expand All @@ -55,11 +57,8 @@ TEST(AggTest, basic_test) {
for (int i = 0; i < agg_test_batch_size; i++) {
ans += i;
}
ASSERT_EQ(ans, *(int32_t*)place);
ASSERT_EQ(ans, *reinterpret_cast<int32_t*>(place));
agg_function->destroy(place);
if (place) {
free(place);
}
}

TEST(AggTest, topn_test) {
Expand All @@ -80,7 +79,8 @@ TEST(AggTest, topn_test) {
Array array;

auto agg_function = factory.get("topn", data_types, array);
AggregateDataPtr place = new char[agg_function->size_of_data()];
std::unique_ptr<char[]> memory(new char[agg_function->size_of_data()]);
AggregateDataPtr place = memory.get();
agg_function->create(place);

IColumn* columns[2] = {datas[0].get(), datas[1].get()};
Expand Down