[Enhancement] (image) check image validity as soon as generated #9011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
…le exception happens
lide-reed
approved these changes
Apr 25, 2022
| if (latestInvalidImage.delete()) { | ||
| LOG.info(latestInvalidImage.getAbsoluteFile() + " deleted."); | ||
| } else { | ||
| LOG.warn(latestInvalidImage.getAbsoluteFile() + " delete failed."); |
Contributor
There was a problem hiding this comment.
Can it print the reason to the warning log if delete failed
Contributor
Author
There was a problem hiding this comment.
It will print the exception to the warning log as error.
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
weizhengte
pushed a commit
to weizhengte/incubator-doris
that referenced
this pull request
Apr 25, 2022
…he#9011) * load newly generated image file as soon as generated to check if it is valid. * delete the latest invalid image file * fix * fix * get filePath from saveImage() to ensure deleting the correct file while exception happens * fix Co-authored-by: wuhangze <wuhangze@jd.com> (cherry picked from commit bdf915a)
weizhengte
pushed a commit
to weizhengte/incubator-doris
that referenced
this pull request
Apr 26, 2022
…he#9011) * load newly generated image file as soon as generated to check if it is valid. * delete the latest invalid image file * fix * fix * get filePath from saveImage() to ensure deleting the correct file while exception happens * fix Co-authored-by: wuhangze <wuhangze@jd.com> (cherry picked from commit bdf915a)
morningman
added
dev/merged-1.0.1-deprecated
morningman
pushed a commit
that referenced
this pull request
Apr 26, 2022
* load newly generated image file as soon as generated to check if it is valid. * delete the latest invalid image file * fix * fix * get filePath from saveImage() to ensure deleting the correct file while exception happens * fix Co-authored-by: wuhangze <wuhangze@jd.com>
3 tasks
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Apr 27, 2022
morningman
added a commit
that referenced
this pull request
Apr 28, 2022
morningman
added a commit
that referenced
this pull request
Apr 28, 2022
zhengshiJ
pushed a commit
to zhengshiJ/incubator-doris
that referenced
this pull request
Apr 29, 2022
Kikyou1997
pushed a commit
to Kikyou1997/incubator-doris
that referenced
this pull request
May 9, 2022
…he#9011) * load newly generated image file as soon as generated to check if it is valid. * delete the latest invalid image file * fix * fix * get filePath from saveImage() to ensure deleting the correct file while exception happens * fix Co-authored-by: wuhangze <wuhangze@jd.com>
Kikyou1997
pushed a commit
to Kikyou1997/incubator-doris
that referenced
this pull request
May 9, 2022
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
…he#9011) * load newly generated image file as soon as generated to check if it is valid. * delete the latest invalid image file * fix * fix * get filePath from saveImage() to ensure deleting the correct file while exception happens * fix Co-authored-by: wuhangze <wuhangze@jd.com>
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
…he#9011) * load newly generated image file as soon as generated to check if it is valid. * delete the latest invalid image file * fix * fix * get filePath from saveImage() to ensure deleting the correct file while exception happens * fix Co-authored-by: wuhangze <wuhangze@jd.com>
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load newly generated image file as soon as generated to check if it is valid.
Proposed changes
Issue Number: close #9010
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...