keep at least one validated image file #9192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lide-reed
approved these changes
Apr 25, 2022
Contributor
lide-reed
left a comment
lide-reed
left a comment
There was a problem hiding this comment.
LGTM, it's really a nice way to keep validated image rather than last image that may be corrupt.
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
weizhengte
pushed a commit
to weizhengte/incubator-doris
that referenced
this pull request
Apr 25, 2022
* rename ImageSeq to LatestImageSeq in Storage * keep at least one validated image file (cherry picked from commit 687421b)
weizhengte
pushed a commit
to weizhengte/incubator-doris
that referenced
this pull request
Apr 26, 2022
* rename ImageSeq to LatestImageSeq in Storage * keep at least one validated image file (cherry picked from commit 687421b)
morningman
added
dev/1.0.1-deprecated
morningman
pushed a commit
that referenced
this pull request
Apr 26, 2022
* rename ImageSeq to LatestImageSeq in Storage * keep at least one validated image file
Kikyou1997
pushed a commit
to Kikyou1997/incubator-doris
that referenced
this pull request
May 9, 2022
* rename ImageSeq to LatestImageSeq in Storage * keep at least one validated image file
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
* rename ImageSeq to LatestImageSeq in Storage * keep at least one validated image file
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
* rename ImageSeq to LatestImageSeq in Storage * keep at least one validated image file
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
We should keep at least one validated image file and edit log. #9011 achieve the goal by running loadImage just after the image file is generated, then we keep an image file generated just now. It works too. However, we should assure the newly generated file is flushed to disk, actually it is hard due to cache on disk itself especially if a power off happened.
Because I wrote the code yesterday, and noted by @caiconghui today that #9011 did the similar job. So I send out the code for discussing.
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...