Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Apr 21, 2022

Proposed changes

Issue Number: close #9159

Problem Summary:

  1. fix bug described in [Bug] partition's storage medium change from HDD back to SSD after FE restart #9159
  2. fix a fill_tuple bug introduced from [fix](broker load) sync the workflow of BrokerScanner to other Scanner to avoid oom #9173

Checklist(Required)

  1. Does it affect the original behavior: (No)
  2. Has unit tests been added: (No Need)
  3. Has document been added or modified: (No Need)
  4. Does it need to update dependencies: (No)
  5. Are there any changes that cannot be rolled back: (No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman changed the title Hdd to ssd [fix](hierarchical-storage) Fix bug that storage medium property change back to SSD Apr 21, 2022
@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/catalog Issues or PRs related to catalog management dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Apr 21, 2022
hf200012
hf200012 previously approved these changes Apr 24, 2022
Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 24, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

resultMap.put("status", e.getCode().code());
resultMap.put("exception", e.getMessage());
} catch (Exception e) {
e.printStackTrace();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use log instead

Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 7cfebd0 into apache:master Apr 26, 2022
weizhengte pushed a commit to weizhengte/incubator-doris that referenced this pull request Apr 26, 2022
…ge back to SSD (apache#9158)

1. fix bug described in apache#9159
2. fix a `fill_tuple` bug introduced from apache#9173

(cherry picked from commit 7cfebd0)
kkfnui added a commit to kkfnui/incubator-doris that referenced this pull request Apr 26, 2022
@morningman morningman added dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Apr 26, 2022
morningman added a commit that referenced this pull request Apr 26, 2022
zhengshiJ pushed a commit to zhengshiJ/incubator-doris that referenced this pull request May 9, 2022
…ge back to SSD (apache#9158)

1. fix bug described in apache#9159
2. fix a `fill_tuple` bug introduced from apache#9173
Kikyou1997 pushed a commit to Kikyou1997/incubator-doris that referenced this pull request May 9, 2022
…ge back to SSD (apache#9158)

1. fix bug described in apache#9159
2. fix a `fill_tuple` bug introduced from apache#9173
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
…ge back to SSD (apache#9158)

1. fix bug described in apache#9159
2. fix a `fill_tuple` bug introduced from apache#9173
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
…ge back to SSD (apache#9158)

1. fix bug described in apache#9159
2. fix a `fill_tuple` bug introduced from apache#9173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 kind/fix Categorizes issue or PR as related to a bug. kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] partition's storage medium change from HDD back to SSD after FE restart

4 participants