-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](hierarchical-storage) Fix bug that storage medium property change back to SSD #9158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hf200012
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
EmmyMiao87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| resultMap.put("status", e.getCode().code()); | ||
| resultMap.put("exception", e.getMessage()); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use log instead
EmmyMiao87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…ge back to SSD (apache#9158) 1. fix bug described in apache#9159 2. fix a `fill_tuple` bug introduced from apache#9173 (cherry picked from commit 7cfebd0)
…ge back to SSD Use apache#9158 fix. merge without any test
…ge back to SSD (apache#9158) 1. fix bug described in apache#9159 2. fix a `fill_tuple` bug introduced from apache#9173
…ge back to SSD (apache#9158) 1. fix bug described in apache#9159 2. fix a `fill_tuple` bug introduced from apache#9173
…ge back to SSD (apache#9158) 1. fix bug described in apache#9159 2. fix a `fill_tuple` bug introduced from apache#9173
…ge back to SSD (apache#9158) 1. fix bug described in apache#9159 2. fix a `fill_tuple` bug introduced from apache#9173
Proposed changes
Issue Number: close #9159
Problem Summary:
fill_tuplebug introduced from [fix](broker load) sync the workflow of BrokerScanner to other Scanner to avoid oom #9173Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...