Skip to content

Conversation

@SleepyBear96
Copy link
Contributor

@SleepyBear96 SleepyBear96 commented Apr 22, 2022

Proposed changes

Issue Number: close #9185

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

morningman
morningman previously approved these changes Apr 23, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/broker-load dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Apr 23, 2022
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 23, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

Hi @SleepyBear96 Please also create an issue to describe the problem you solved.

@SleepyBear96 SleepyBear96 changed the title [fix](broker load) sync the control flow of BrokerScanner to other Scanner to avoid oom [fix](broker load) sync the workflow of BrokerScanner to other Scanner to avoid oom Apr 24, 2022
@SleepyBear96
Copy link
Contributor Author

Hi @SleepyBear96 Please also create an issue to describe the problem you solved.

Done.

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If both of all child scanner have same method, you better impl the funciton in BaseScanner

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 24, 2022
@SleepyBear96
Copy link
Contributor Author

If both of all child scanner have same method, you better impl the funciton in BaseScanner

Done.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 24, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit c3d0fee into apache:master Apr 25, 2022
morningman added a commit that referenced this pull request Apr 26, 2022
…ge back to SSD (#9158)

1. fix bug described in #9159
2. fix a `fill_tuple` bug introduced from #9173
weizhengte pushed a commit to weizhengte/incubator-doris that referenced this pull request Apr 26, 2022
…ge back to SSD (apache#9158)

1. fix bug described in apache#9159
2. fix a `fill_tuple` bug introduced from apache#9173

(cherry picked from commit 7cfebd0)
@SleepyBear96 SleepyBear96 deleted the patch-1 branch April 26, 2022 11:37
@morningman morningman added dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Apr 26, 2022
morningman pushed a commit that referenced this pull request Apr 26, 2022
zhengshiJ pushed a commit to zhengshiJ/incubator-doris that referenced this pull request Apr 27, 2022
zhengshiJ pushed a commit to zhengshiJ/incubator-doris that referenced this pull request May 9, 2022
…ge back to SSD (apache#9158)

1. fix bug described in apache#9159
2. fix a `fill_tuple` bug introduced from apache#9173
Kikyou1997 pushed a commit to Kikyou1997/incubator-doris that referenced this pull request May 9, 2022
Kikyou1997 pushed a commit to Kikyou1997/incubator-doris that referenced this pull request May 9, 2022
…ge back to SSD (apache#9158)

1. fix bug described in apache#9159
2. fix a `fill_tuple` bug introduced from apache#9173
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
…ge back to SSD (apache#9158)

1. fix bug described in apache#9159
2. fix a `fill_tuple` bug introduced from apache#9173
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
…ge back to SSD (apache#9158)

1. fix bug described in apache#9159
2. fix a `fill_tuple` bug introduced from apache#9173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/broker-load dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] load orc format bitmap by broker load will exhaust memory

5 participants