DRILL-8323: upgrade commons-text to 1.10.0 #2663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r that has a transitive dependency on it)
cgivre
approved these changes
Sep 29, 2022
Contributor
cgivre
left a comment
cgivre
left a comment
There was a problem hiding this comment.
Pending CI, LGTM +1
Thanks @pjfanning for this.
pjfanning
commented
Sep 29, 2022
| .singletonDouble(); | ||
| assertEquals(0.7142857142857143, result, 0.0); | ||
| assertEquals(0.2857142857142857, result, 0.0); | ||
| } |
Member
Author
There was a problem hiding this comment.
change needed because of https://issues.apache.org/jira/browse/TEXT-191
cgivre
added
minor-update
dependencies
backport-to-stable
ZbigniewTomanek
pushed a commit
to ZbigniewTomanek/drill
that referenced
this pull request
Dec 1, 2022
(cherry picked from commit 32d4e68)
kingswanwho
pushed a commit
to kingswanwho/drill
that referenced
this pull request
Dec 9, 2022
kingswanwho
pushed a commit
to kingswanwho/drill
that referenced
this pull request
Dec 18, 2022
jnturton
pushed a commit
that referenced
this pull request
Dec 19, 2022
ashevchuk123
pushed a commit
to mapr/incubator-drill
that referenced
this pull request
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and excel-streaming-reader that has a transitive dependency on it)
Description
Some important bugs fixed in latest version
Fixes include https://issues.apache.org/jira/browse/TEXT-191 and this affects one of the Drill tests - I fixed the test to match the new correct result from commons-text 1.10.0