Skip to content

DRILL-8323: upgrade commons-text to 1.10.0 #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgivre merged 2 commits into from
Sep 29, 2022
+5 −5
Merged

DRILL-8323: upgrade commons-text to 1.10.0 #2663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2917ee5
DRILL-8323: upgrade commons-text to 1.10.0 (and excel-streaming-reade…
pjfanning Sep 29, 2022
9cfb3cc
fix tests
pjfanning Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contrib/format-excel/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
<dependency>
<groupId>com.github.pjfanning</groupId>
<artifactId>excel-streaming-reader</artifactId>
<version>4.0.2</version>
<version>4.0.3</version>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
Expand Down
6 changes: 3 additions & 3 deletions contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestStringDistanceFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,15 @@ public void testJaccardDistance() throws Exception {
double result = queryBuilder()
.sql("select jaccard_distance( 'Big car', 'red car' ) as distance FROM (VALUES(1))")
.singletonDouble();
assertEquals(0.56, result, 0.0);
assertEquals(0.5555555555555556, result, 0.0);
}

@Test
public void testJaroDistance() throws Exception {
double result = queryBuilder()
.sql("select jaro_distance( 'Big car', 'red car' ) as distance FROM (VALUES(1))")
.singletonDouble();
assertEquals(0.7142857142857143, result, 0.0);
assertEquals(0.2857142857142857, result, 0.0);
}
Copy link
Member Author

@pjfanning pjfanning Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change needed because of https://issues.apache.org/jira/browse/TEXT-191


@Test
Expand All @@ -77,4 +77,4 @@ public void testLevenshteinDistance() throws Exception {
.singletonDouble();
assertEquals(3.0, result, 0.0);
}
}
}
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
<maven.min.version>3.6.3</maven.min.version>
<commons.net.version>3.6</commons.net.version>
<commons.validator.version>1.6</commons.validator.version>
<commons.text.version>1.6</commons.text.version>
<commons.text.version>1.10.0</commons.text.version>
<protobuf.version>3.16.1</protobuf.version>
<protostuff.version>1.7.1</protostuff.version>
<codemodel.version>2.6</codemodel.version>
Expand Down