Description
Some of the metrics on the Prometheus emitter are missing, and some lack labels.
The ones that are missing are basically the ones added in this PR.
The one that is missing a label is service/heartbeat and it's missing the dimension (label) leader.
Motivation
Currently, we're passing our custom metrics.json to the prometheus emitter, and each time we do an upgrade, we need to also to make sure to update that file, which sometimes can be tedious from an operational point of view to do it on each upgrade. It would be nice if we could include these dimensions and metrics in the JSON file in the upstream.
Description
Some of the metrics on the Prometheus emitter are missing, and some lack labels.
The ones that are missing are basically the ones added in this PR.
The one that is missing a label is
service/heartbeatand it's missing the dimension (label)leader.Motivation
Currently, we're passing our custom
metrics.jsonto the prometheus emitter, and each time we do an upgrade, we need to also to make sure to update that file, which sometimes can be tedious from an operational point of view to do it on each upgrade. It would be nice if we could include these dimensions and metrics in the JSON file in the upstream.