Skip to content

feat: add groupby metrics to prometheus emitter#17929

Merged
gianm merged 1 commit intoapache:masterfrom
TessaIO:feat-add-groupby-metrics-to-prometheus-emitter
Apr 16, 2025
Merged

feat: add groupby metrics to prometheus emitter#17929
gianm merged 1 commit intoapache:masterfrom
TessaIO:feat-add-groupby-metrics-to-prometheus-emitter

Conversation

@TessaIO
Copy link
Copy Markdown
Contributor

@TessaIO TessaIO commented Apr 16, 2025

Fixes #17908.

Description

Add Groupby metrics to Prometheus emitter

Release note


Add Groupby metrics to Prometheus emitter


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
@TessaIO
Copy link
Copy Markdown
Contributor Author

TessaIO commented Apr 16, 2025

cc @gianm

Copy link
Copy Markdown
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Note for possible future work: similar changes could likely be made to the statsd, opentsdb, etc emitters, or we could unify the configs. Many emitters have some way of defining what metrics are emitted using JSON files, although the default versions of those JSON files haven't yet been unified. (You don't have to do this, I'm just writing it in case anyone looks and wonders about other emitters.)

@gianm gianm merged commit 7691fb1 into apache:master Apr 16, 2025
42 checks passed
@capistrant capistrant added this to the 34.0.0 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing metrics and labels to Prometheus emitter

3 participants