BatchServerInventoryView is created twice

[drcrallen]

Brokers retain two copies of BatchServerInventoryView. One through BatchServerInventoryViewProvider and one through FilteredBatchServerInventoryViewProvider. This causes excessive use of heap when there are a large quantity of segments and servers.

[drcrallen]

This is a 0.9.1 regression from #2848

[drcrallen]

Here's an example of the Eclipse MAT analysis of a heap dump from one of the brokers.

[gianm]

Why does the broker need both? Shouldn't it only have a FilteredServerInventoryView?

[drcrallen]

@himanshug / @nishantmonu51 ^^^^?

[gianm]

It looks like the one place it asks for injection of a ServerInventoryView instead of FilteredServerInventoryView is DruidBroker.java. Switching that to a FilteredServerInventoryView should work too and seems like a cleaner solution.

[drcrallen]

@gianm I'd like to get #3238 anyways so the space that replicants of a segment take up are minimized

[nishantmonu51]

agree with @gianm DruidBroker needs to be fixed to use FilteredServerInventoryView
will submit a fix shorty.