fix-3237 modify DruidBroker to use FilteredServerInventoryView instead of ServerInventoryView#3244
Merged
drcrallen merged 1 commit intoapache:masterfrom Jul 14, 2016
Merged
Conversation
Contributor
|
👍 LGTM @nishantmonu51 did you confirm that this avoids creation of multiple views? |
Contributor
|
@nishantmonu51 can you make the title reflect what it does (it will be the commit title when squashed). The fixing info should go in the master comment. |
Contributor
|
sorry, doesn't become commit title unless there's lots of commits in squash |
nishantmonu51
changed the title
Member
Author
|
@gianm I confirmed by taking a object histogram which showed only 1 instance |
Contributor
|
👍 |
drcrallen
pushed a commit
to metamx/druid
that referenced
this pull request
Jul 19, 2016
DruidBroker use FilteredServerInventoryView instead of ServerInventoryView
seoeun25
added a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
* Optional segment announcement via HTTP (apache#3902) * BatchServerInventoryView is created twice (apache#3244)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modify DruidBroker to use FilteredServerInventoryView instead of
ServerInventoryView to avoid multiple copies of ServerInventoryView getting created.
fixes #3237