Web console: Remove first / last suggestions#10794
Merged
jihoonson merged 2 commits intoapache:masterfrom Jan 28, 2021
Merged
Conversation
jihoonson
approved these changes
Jan 25, 2021
Contributor
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
LGTM. I left a nit comment on the code style.
Comment on lines
+73
to
+80
| // { | ||
| // group: 'first', | ||
| // suggestions: ['longFirst', 'doubleFirst', 'floatFirst'], | ||
| // }, | ||
| // { | ||
| // group: 'last', | ||
| // suggestions: ['longLast', 'doubleLast', 'floatLast'], | ||
| // }, |
Contributor
There was a problem hiding this comment.
We don't usually allow commented out code in java code. Do you think it's better to be consistent in the web-console as well?
Contributor
|
I don't think this fixes #10702 IMO it should still be an open issue, this fix makes it less likely that someone will trip on this from the UI |
Member
Contributor
@FrankChen021 that's great news! Looking forward to the PR! |
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
Feb 2, 2021
* Remove first / last suggestions * remove commened out code
jihoonson
added a commit
that referenced
this pull request
Feb 3, 2021
FrankChen021
added a commit
to FrankChen021/druid
that referenced
this pull request
Mar 5, 2021
This reverts commit 2a1e47a.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment out some optimistic suggestion until such a time when they will be possible at ingestion time.
Related to #10702