Skip to content

Web console: Remove first / last suggestions #10794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jihoonson merged 2 commits into from
Jan 28, 2021
Merged

Web console: Remove first / last suggestions #10794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90993d9
Remove first / last suggestions
vogievetsky Jan 24, 2021
d0db4bf
remove commened out code
vogievetsky Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions web-console/src/druid-models/metric-spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,10 @@ export const METRIC_SPEC_FIELDS: Field<MetricSpec>[] = [
group: 'max',
suggestions: ['longMax', 'doubleMax', 'floatMax'],
},
{
group: 'first',
suggestions: ['longFirst', 'doubleFirst', 'floatFirst'],
},
{
group: 'last',
suggestions: ['longLast', 'doubleLast', 'floatLast'],
},
// Do not show first and last aggregators as they can not be used in ingestion specs and this definition is only used in the data loader.
// Ref: https://druid.apache.org/docs/latest/querying/aggregations.html#first--last-aggregator
// Should the first / last aggregators become usable at ingestion time, reverse the changes made in:
// https://github.com/apache/druid/pull/10794
'thetaSketch',
{
group: 'HLLSketch',
Expand Down