Update doc for query errors and add unit tests for JsonParserIterator#10833
Merged
clintropolis merged 4 commits intoapache:masterfrom Feb 5, 2021
Merged
Update doc for query errors and add unit tests for JsonParserIterator#10833clintropolis merged 4 commits intoapache:masterfrom
clintropolis merged 4 commits intoapache:masterfrom
Conversation
clintropolis
reviewed
Feb 2, 2021
| public static final String ERROR_CODE = "Resource limit exceeded"; | ||
|
|
||
| public ResourceLimitExceededException(String message, Object... arguments) | ||
| public ResourceLimitExceededException(String message) |
Member
There was a problem hiding this comment.
hmm, the built in format seemed useful and cleaner than having callers deal with it everywhere, and consistent with many of our other exceptions, why this change?
Contributor
Author
There was a problem hiding this comment.
I made a mistake in my previous PR that creates a ResourceLimitExceededException by calling new ResourceLimitExceededException(errorCode, message, errorClass, host) which actually calls ResourceLimitExceededException(String message, Object... arguments). I didn't notice my mistake until I add a test for it because Intellij says you are cool. This change was to avoid such mistakes, but I agree it is useful. I added a static constructor that does the same.
clintropolis
approved these changes
Feb 4, 2021
clintropolis
approved these changes
Feb 5, 2021
9 tasks
jihoonson
added a commit
to jihoonson/druid
that referenced
this pull request
Apr 12, 2021
…apache#10833) * Update doc for query errors and add unit tests for JsonParserIterator * static constructor for convenience * rename method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A follow-up of #10746. This PR updates the query error doc and adds unit tests for
JsonParserIterator. Integration tests will be added in another PR.This PR has: