Skip to content

More unit tests for JsonParserIterator; Integration tests for query errors#11091

Merged
jihoonson merged 4 commits intoapache:masterfrom
jihoonson:query-error-tests
Apr 12, 2021
Merged

More unit tests for JsonParserIterator; Integration tests for query errors#11091
jihoonson merged 4 commits intoapache:masterfrom
jihoonson:query-error-tests

Conversation

@jihoonson
Copy link
Copy Markdown
Contributor

@jihoonson jihoonson commented Apr 10, 2021

Fixes #10756.

Description

A follow-up of #10833. This PR adds more unit tests for JsonParserIterator and integration tests for query errors changed in #10746. To easily test query errors from historicals, ServerManagerForQueryErrorTest is refactored to mimic other query failures.

Key changed/added classes in this PR
  • ITQueryErrorTest
  • ServerManagerForQueryErrorTest

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jihoonson jihoonson changed the title Query error tests More unit tests for JsonParserIterator; Integraion tests for query errors Apr 10, 2021
@clintropolis clintropolis changed the title More unit tests for JsonParserIterator; Integraion tests for query errors More unit tests for JsonParserIterator; Integration tests for query errors Apr 10, 2021
@jihoonson jihoonson added this to the 0.21.0 milestone Apr 10, 2021
@jihoonson jihoonson merged commit a6a2758 into apache:master Apr 12, 2021
jihoonson added a commit to jihoonson/druid that referenced this pull request Apr 13, 2021
@jihoonson
More unit tests for JsonParserIterator; Integration tests for query e…
67a5bee 
…rrors (apache#11091)

* unit tests for timeout exception in init

* integration tests

* run integraion test on travis

* fix inspection
@jihoonson jihoonson mentioned this pull request Apr 13, 2021
Merged
jihoonson added a commit that referenced this pull request Apr 13, 2021
@jihoonson
More unit tests for JsonParserIterator; Integration tests for query e…
4966eeb 
…rrors (#11091) (#11108)

* unit tests for timeout exception in init

* integration tests

* run integraion test on travis

* fix inspection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maytasm maytasm maytasm approved these changes

Assignees

No one assigned

Labels

Area - Querying Area - SQL Area - Testing

Projects

None yet

Milestone

0.21.0

Development

Successfully merging this pull request may close these issues.

Add missing tests and docs for modified query error codes

2 participants

@jihoonson @maytasm