Add log message when local input's filter does not match any files#10837
Merged
a2l007 merged 2 commits intoapache:masterfrom Feb 5, 2021
Merged
Add log message when local input's filter does not match any files#10837a2l007 merged 2 commits intoapache:masterfrom
a2l007 merged 2 commits intoapache:masterfrom
Conversation
loquisgon
commented
Feb 3, 2021
suneet-s
approved these changes
Feb 3, 2021
Contributor
suneet-s
left a comment
suneet-s
left a comment
There was a problem hiding this comment.
LGTM - travis failures appear to be because of an issue with something in master
a2l007
approved these changes
Feb 5, 2021
Contributor
a2l007
left a comment
a2l007
left a comment
There was a problem hiding this comment.
This is useful! Thanks @loquisgon
I've restarted the build to see if it helps.
Contributor
|
The leadership test failures were fixed in #10846 so I think it's ok to overrule Travis for this change. EDIT: I eat my words - looks like Travis passed now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide information in the log when the filter for local inputSource does not match any files
Expected behavior
When the filter for local inputSource does not match any file a log message should be output at
INFOlevel indicating that "no files matched the filter expression:.Actual behavior
When the filter for local inputSource does not match any file there is no log message, the task report simply indicates that no rows were parsed.
Key changes:
Added a logger & log message to class
LocalInputSource.javato match the expected behavior as outlined above.