Skip to content

Add log message when local input's filter does not match any files #10837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a2l007 merged 2 commits into from
Feb 5, 2021
Merged

Add log message when local input's filter does not match any files #10837

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9b3a87
Add log message when local input's filter does not match any files
Feb 3, 2021
c2a09e4
Re-use previously defined fileIterator
Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/src/main/java/org/apache/druid/data/input/impl/LocalInputSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import org.apache.druid.data.input.InputSplit;
import org.apache.druid.data.input.SplitHintSpec;
import org.apache.druid.java.util.common.IAE;
import org.apache.druid.java.util.common.logger.Logger;
import org.apache.druid.utils.CollectionUtils;
import org.apache.druid.utils.Streams;

Expand All @@ -56,6 +57,8 @@

public class LocalInputSource extends AbstractInputSource implements SplittableInputSource<List<File>>
{
private static final Logger log = new Logger(LocalInputSource.class);

@Nullable
private final File baseDir;
@Nullable
Expand Down Expand Up @@ -151,11 +154,17 @@ private Iterator<File> getDirectoryListingIterator()
)
);
}
return FileUtils.iterateFiles(
Iterator<File> fileIterator = FileUtils.iterateFiles(
baseDir.getAbsoluteFile(),
fileFilter,
TrueFileFilter.INSTANCE
);
if (!fileIterator.hasNext()) {
// base dir & filter are guaranteed to be non-null here
// (by construction and non-null check of baseDir a few lines above):
log.info("Local inputSource filter [%s] for base dir [%s] did not match any files", filter, baseDir);
}
Comment thread
loquisgon marked this conversation as resolved.
return fileIterator;
}
}

Expand Down