First refactor of compaction docs#10935
Merged
maytasm merged 18 commits intoapache:masterfrom Mar 24, 2021
Merged
Conversation
9 tasks
2bethere
reviewed
Mar 5, 2021
2bethere
reviewed
Mar 5, 2021
Contributor
2bethere
left a comment
There was a problem hiding this comment.
Thanks for putting this up! I think it's a much-needed improvement. Added some comments.
sthetland
requested changes
Mar 9, 2021
sthetland
left a comment
There was a problem hiding this comment.
Comments & suggestions below.. Looks good though! It makes compaction clearer.
suneet-s
reviewed
Mar 11, 2021
suneet-s
reviewed
Mar 11, 2021
suneet-s
reviewed
Mar 11, 2021
suneet-s
reviewed
Mar 11, 2021
suneet-s
reviewed
Mar 11, 2021
Contributor
|
I echo others comments on this PR. This is a huge improvement - thank you @techdocsmith ! I haven't verified the correctness of how exactly compaction works, or the details of the different tuning knobs Some overall structural feedback (doesn't need to be addressed in this PR):
|
maytasm
requested changes
Mar 13, 2021
suneet-s
reviewed
Mar 16, 2021
6 tasks
Contributor
|
Docs failure looks legit |
Contributor
Author
|
Apologize for that @suneet-s , I fixed links and spelling in a later commit. |
maytasm
requested changes
Mar 19, 2021
…anularity. removes duplicated doc
2a3bbb5 to
bee7f74
Compare
add granularityspec to example
maytasm
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10897
First pass refactor / update of compaction docs
Updates to "Data management" topic as follows:
Adds a new topic "Compaction" that defines compaction and automatic compaction as a strategy for segment optimization.
Repairs links for the refactor above.
This PR doesn't handle the remaining task of identifying reindexing and compaction as data management tasks for existing data and comparing the use cases between the two. This should come in a subsequent PR.
cc: @maytasm, @suneet-s , @loquisgon , @sthetland
This PR has: