CompactionTask throws exception on conflicting segmentGranularity#10996
Merged
maytasm merged 2 commits intoapache:masterfrom Mar 16, 2021
Merged
CompactionTask throws exception on conflicting segmentGranularity#10996maytasm merged 2 commits intoapache:masterfrom
maytasm merged 2 commits intoapache:masterfrom
Conversation
suneet-s
commented
Mar 16, 2021
| this.segmentGranularity = segmentGranularity; | ||
| if (granularitySpec != null | ||
| && segmentGranularity != null | ||
| && !segmentGranularity.equals(granularitySpec.getSegmentGranularity())) { |
Contributor
Author
There was a problem hiding this comment.
I couldn't decide what it means to have a granularitySpec.getSegmentGranularity() be null and segmentGranularity be non null, so I figured it would be good to flag that as a conflict as well
2 tasks
Contributor
Author
|
maytasm
approved these changes
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A follow up to #10843
Since there are 2 ways for a user to specify segmentGranularity - this change makes throws an exception if a user accidentally submits a compaction task with conflicting segmentGranularities - by using the old way and the new way at the same time.
This PR has: