LongsLongEncodingReader: Implement "duplicate", fixing concurrency bug.#11098
Merged
gianm merged 1 commit intoapache:masterfrom Apr 13, 2021
Merged
LongsLongEncodingReader: Implement "duplicate", fixing concurrency bug.#11098gianm merged 1 commit intoapache:masterfrom
gianm merged 1 commit intoapache:masterfrom
Conversation
Regression introduced in apache#11004 due to overzealous optimization. Even though we replaced stateful usage of ByteBuffer with stateless usage of Memory, we still need to create a new object on "duplicate" due to semantics of setBuffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression introduced in #11004 due to overzealous optimization. Even though
we replaced stateful usage of ByteBuffer with stateless usage of Memory, we
still need to create a new object on "duplicate" due to semantics of setBuffer.
This issue was causing LongFilteringTest.testMultithreaded to be flaky. I didn't
add new tests for this issue, because LongFilteringTest.testMultithreaded already
covers it — it's just that the flaky test retrier was too zealous in retrying. Maybe
we should tune it down a bit (perhaps create a list of known-flaky tests and
don't retry others?)
Credit to @clintropolis for noticing this.