Skip to content

LongsLongEncodingReader: Implement "duplicate", fixing concurrency bug. #11098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianm merged 1 commit into from
Apr 13, 2021
Merged

LongsLongEncodingReader: Implement "duplicate", fixing concurrency bug. #11098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions processing/src/main/java/org/apache/druid/segment/data/CompressionFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,11 @@ public interface LongEncodingReader

int read(long[] out, int outPosition, int[] indexes, int length, int indexOffset, int limit);

/**
* Duplicates this reader, creating a new reader that does not share any state. Important to achieve thread-safety,
* because a common pattern is to duplicate a reader multiple times and then call {@link #setBuffer} on the
* various duplicates.
*/
LongEncodingReader duplicate();
}

Expand Down
2 changes: 1 addition & 1 deletion processing/src/main/java/org/apache/druid/segment/data/LongsLongEncodingReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,6 @@ public int read(long[] out, int outPosition, int[] indexes, int length, int inde
@Override
public CompressionFactory.LongEncodingReader duplicate()
{
return this;
return new LongsLongEncodingReader(buffer.getByteBuffer(), buffer.getTypeByteOrder());
}
}