Revert permission changes to Supervisor and Task APIs#11819
Merged
abhishekagarwal87 merged 5 commits intoapache:masterfrom Oct 25, 2021
Merged
Revert permission changes to Supervisor and Task APIs#11819abhishekagarwal87 merged 5 commits intoapache:masterfrom
abhishekagarwal87 merged 5 commits intoapache:masterfrom
Conversation
…k access (apache#11718)" This reverts commit f2d6100.
…nd TaskResourceFilter (apache#11680)" This reverts commit 6779c46.
clintropolis
approved these changes
Oct 21, 2021
Contributor
|
Merged since CI failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #11718 and #11680
Description
Changing the required permission level for ALL Supervisor and Task APIs may break existing
automation that users might have set up.
The motivation behind the above mentioned changes were to prevent leakage of sensitive
information through these APIs. But there are other workarounds to prevent that, such as
using
EnvironmentVariableDynamicConfigProviderto provide passwords and secrets.While the above mentioned changes do prevent such leakage of information, they do so
at the cost of unreasonable restrictions on even purely informative APIs. The original changes
also remove the possibility of having a user who needs to view Supervisor and Task information
but should not have permission to ingest data, modify compaction configuration etc. These are
typically support users managing a cluster.
Keeping these arguments in mind, the changes are being reverted. A better solution to these
problems would be a more granular auth model in Druid.
Changes being reverted
This PR has: