Add authentication call before cleaning up intermediate files in hadoop ingestions#12030
Merged
capistrant merged 4 commits intoapache:masterfrom May 2, 2022
Merged
Conversation
added 2 commits
December 7, 2021 09:30
Contributor
Author
|
@zachjsh could you take a peek at this when you have a chance? I'm not positive but am thinking it is related to a change you made in the past |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
Contributor
Author
|
don't close |
|
This issue is no longer marked as stale. |
a2l007
approved these changes
Apr 26, 2022
Contributor
a2l007
left a comment
a2l007
left a comment
There was a problem hiding this comment.
Fix looks reasonable, Thanks for your patience!
Contributor
Author
|
Thanks @a2l007! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Druid Version: 0.22.0
Hadoop Version: 3.3.0
Fixed issue observed in hadoop ingestion intermediate file cleanup
I observed my hadoop tasks running against my kerberized hadoop cluster having authentication failures when trying to cleanup intermediate files during hadoop ingestion after upgrading to 0.22.X (from 0.20.X). This is a similar issue to what I had seen in the past when the job went into a graceful shutdown of a hadoop ingestion job (#9785). I'm suspicious that moving the file deletes into their own static JobHelper method introduced this experience I am seeing (#11194). The call to authenticate is idempotent. If the authentication is already done, no action will be taken.
I added a debug log to help people trouble shooting potential issues in the future.Key changed/added classes in this PR
JobHelperThis PR has: