Skip to content

Add authentication call before cleaning up intermediate files in hadoop ingestions #12030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
capistrant merged 4 commits into from
May 2, 2022
Merged

Add authentication call before cleaning up intermediate files in hadoop ingestions #12030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40af311
Add authentication call before cleaning up intermediate files in hado…
Dec 6, 2021
6a6494a
fix checkstyle
Dec 7, 2021
054fb76
remove debug log
Dec 8, 2021
17a327c
Merge branch 'master' into index-hadoop-authenticate-before-cleanup
Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e/hdfs-storage/src/main/java/org/apache/druid/storage/hdfs/HdfsStorageAuthentication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public HdfsStorageAuthentication(HdfsKerberosConfig hdfsKerberosConfig, @Hdfs Co
}

/**
* Dose authenticate against a secured hadoop cluster
* Does authenticate against a secured hadoop cluster
* In case of any bug fix make sure to fix the code in JobHelper#authenticate as well.
*/
@LifecycleStart
Expand Down
5 changes: 4 additions & 1 deletion indexing-hadoop/src/main/java/org/apache/druid/indexer/JobHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public static Path distributedClassPath(Path base)
public static final String INDEX_ZIP = "index.zip";

/**
* Dose authenticate against a secured hadoop cluster
* Does authenticate against a secured hadoop cluster
* In case of any bug fix make sure to fix the code at HdfsStorageAuthentication#authenticate as well.
*
*/
Expand Down Expand Up @@ -409,6 +409,9 @@ public static void maybeDeleteIntermediatePath(
boolean jobSucceeded,
HadoopIngestionSpec indexerSchema)
{
// Ensure we are authenticated before we try to delete intermediate paths!
authenticate();

HadoopDruidIndexerConfig config = HadoopDruidIndexerConfig.fromSpec(indexerSchema);
final Configuration configuration = JobHelper.injectSystemProperties(new Configuration(), config);
config.addJobProperties(configuration);
Expand Down