Disable auto compaction config cleanup by default#12201
Merged
maytasm merged 1 commit intoapache:masterfrom Jan 27, 2022
Merged
Disable auto compaction config cleanup by default#12201maytasm merged 1 commit intoapache:masterfrom
maytasm merged 1 commit intoapache:masterfrom
Conversation
suneet-s
approved these changes
Jan 25, 2022
Contributor
suneet-s
left a comment
suneet-s
left a comment
There was a problem hiding this comment.
👍 Thanks for surfacing this use case. I hadn't considered the scenario where compaction configs are created before a datasource has any data
vtlim
added a commit
to vtlim/druid
that referenced
this pull request
Jan 25, 2022
maytasm
added a commit
that referenced
this pull request
Jan 27, 2022
* doc updates for metadata storage/cleanup * Add comments for disabling cleanup * Apply suggestions from code review * updated for #12201 * Apply suggestions from code review Co-authored-by: Maytas Monsereenusorn <maytasm@apache.org> * move retention period line earlier; more concise text * fix typo Co-authored-by: Maytas Monsereenusorn <maytasm@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable auto compaction config cleanup by default
Description
This revert part of the config change in #12188
Some user may have a work flow / script that create auto compaction config before the datasource is created. Hence, we should not turn the auto compaction config cleanup on by default as those config may get deleted unexpectedly.
This PR has: