use reflection to check for mysql transient exception type#12205
Merged
clintropolis merged 3 commits intoapache:masterfrom Jan 27, 2022
Merged
use reflection to check for mysql transient exception type#12205clintropolis merged 3 commits intoapache:masterfrom
clintropolis merged 3 commits intoapache:masterfrom
Conversation
| if (driverName.contains("mysql")) { | ||
| try { | ||
| Class<?> clazz = Class.forName(MYSQL_TRANSIENT_EXCEPTION_CLASS_NAME, false, classLoader); | ||
| return e.getClass().equals(clazz) |
Contributor
There was a problem hiding this comment.
Suggested change
| return e.getClass().equals(clazz) | |
| return clazz.isAssignableFrom(e.getClass()) |
| { | ||
| if (driverName.contains("mysql")) { | ||
| try { | ||
| Class<?> clazz = Class.forName(MYSQL_TRANSIENT_EXCEPTION_CLASS_NAME, false, classLoader); |
Contributor
There was a problem hiding this comment.
maybe we can do this just once in the constructor? what do you think
| { | ||
| final String driver = "com.mysql.jdbc.Driver"; | ||
| final ClassLoader loader = getClass().getClassLoader(); | ||
| Assert.assertTrue(MySQLConnector.isTransientException(loader, driver, new MySQLTransientException())); |
Contributor
There was a problem hiding this comment.
can you also add a test case for MySQLTransactionRollbackException (a subclass of MysqlTransientException)?
abhishekagarwal87
approved these changes
Jan 27, 2022
Contributor
abhishekagarwal87
left a comment
abhishekagarwal87
left a comment
There was a problem hiding this comment.
LGTM. Thank you @clintropolis for the fix.
jihoonson
approved these changes
Jan 27, 2022
Member
Author
|
ci failures are for code coverage, but integration tests are passing (except for known flake #12171) merging anyway, going to merge anyway |
2 tasks
abhishekagarwal87
pushed a commit
that referenced
this pull request
Feb 1, 2022
) Follow up to #12205 to allow druid-mysql-extensions to work with mysql connector/j 8.x again, which does not contain MySQLTransientException, and while would have had the same problem as mariadb if a transient exception was checked, the new check eagerly loads the class when starting up, causing immediate failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed this in #11402, this change will make the
MySQLConnectorimplementation ofSQLMetadataConnector.connectorIsTransientExceptionnot explode when using MariaDB driver (and added javadocs that only vendor specific errors need handled here). I poked around the MariaDB connector and didn't find any obvious custom transient exceptions to add here for it.