Skip to content

do not explode if mysql transient exception does not exist#12213

Merged
abhishekagarwal87 merged 2 commits intoapache:masterfrom
clintropolis:fix-mysql-transient-exceptions
Feb 1, 2022
Merged

do not explode if mysql transient exception does not exist#12213
abhishekagarwal87 merged 2 commits intoapache:masterfrom
clintropolis:fix-mysql-transient-exceptions

Conversation

@clintropolis
Copy link
Copy Markdown
Member

Description

Follow up to #12205 to allow druid-mysql-extensions to work with mysql connector/j 8.x again, which does not contain MySQLTransientException, and while would have had the same problem as mariadb if a transient exception was checked, the new check eagerly loads the class when starting up, causing immediate failure.

This PR has:

  • been self-reviewed.
  • been tested in a test Druid cluster.

Copy link
Copy Markdown
Contributor

@paul-rogers paul-rogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (non binding)

@abhishekagarwal87 abhishekagarwal87 merged commit 978b8f7 into apache:master Feb 1, 2022
@clintropolis clintropolis deleted the fix-mysql-transient-exceptions branch February 1, 2022 03:42
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants