upgrade Error Prone to 2.11 (requires Java 11) #12306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Java 11 is now required to build with errorprone
xvrl
force-pushed
the
upgrade-error-prone
branch
from
c06600c to
34308c5
Compare
clintropolis
approved these changes
Mar 9, 2022
Member
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
👍
not sure why the tests failed last time, i retriggered the relevant ones (no need to run through all integration tests for this change I think)
TSFenwick
pushed a commit
to TSFenwick/druid
that referenced
this pull request
Apr 11, 2022
The latest version of Error Prone now requires Java 11. Upgrading means we can remove a lot of the maven profile complexity required to run checks with Java 8. This also requires switching our strict build to use Java 11. * update error-prone to 2.11 * remove need for specific maven profiles for Java 8 and Java 15 * fix additional Error Prone warnings with Java 11 * update strict build to use Java 11
This was referenced Aug 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of Error Prone now requires Java 11. Upgrading means we can
remove a lot of the maven profile complexity required to run checks with Java 8.
This also requires switching our strict build to use Java 11.
I don't think we really lose much by not checking with Java 8, and it helps us
future-proof as we officially start supporting more recent Java versions.